Commit Graph

4306 Commits

Author SHA1 Message Date
aherbert 5bcab481f7 Remove public keyword from package level test members 2022-11-30 16:07:08 +00:00
aherbert d879329cd3 Remove empty line 2022-11-30 16:02:38 +00:00
aherbert 23677eb23e Javadoc comment typo 2022-11-30 16:00:26 +00:00
Claudenw 64ed061e6a Collections-817: Update estimateN, estimateIntersection and
estimateUnion

Reworked calculations and updated javadoc.

Added documentation concerning n, intersection, and union calculations
in Shape class.

Modified estimatedIntersection to account for infinite
values in calculations.

Closes #358
2022-11-30 15:59:52 +00:00
Gary Gregory 7b2c1b2b3e
Update changes.xml 2022-11-26 15:32:58 -05:00
Arturo Bernal 954d222aa6
Use Java style array decelerations (#362) 2022-11-26 15:32:07 -05:00
Gary Gregory 81a498b116 Inherit PMD plugin configuration of PMD from parent POM 2022-11-26 07:28:31 -05:00
Gary Gregory 8279d9ba46 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2022-11-26 07:26:41 -05:00
Gary Gregory 8d99d5f9bb Bump pmd from 6.51.0 to 6.52.0 2022-11-26 07:26:28 -05:00
Gary Gregory 6031f5395b Reuse constants 2022-11-25 09:19:47 -05:00
Gary Gregory a8c0df14ca Sort imports 2022-11-25 09:15:28 -05:00
Gary Gregory 5a5d0cb5ed Add GHitHub robots file 2022-11-19 17:53:11 -05:00
yannizhou05 37cd2d8dc1
Fix flaky test in CollectionUtilsTest (#360) 2022-11-15 18:35:41 +00:00
Claude Warren d4a5f9f5f5
Collections-837: Remove HasherCollection
* Removed HasherCollection.

* Moved multiple hashing functions into TestingHashers.
2022-11-12 16:35:40 +00:00
aherbert 69cad46a92 Whitespace formatting 2022-11-09 12:50:06 +00:00
Gary Gregory 9bbfad5db3 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2022-11-07 08:39:36 -05:00
Gary Gregory fd09ecccbd Javadocs and comments
Normalize spelling to "behavior"
2022-11-07 08:39:21 -05:00
Alex Herbert 2b3fae5aaa Use method reference 2022-11-07 09:15:27 +00:00
Gary Gregory d5b38edf52 Format tweak 2022-11-06 11:55:02 -05:00
Gary Gregory 882f005452 Enable PMD check 2022-11-06 11:51:29 -05:00
Gary Gregory 12bdb33dc0 Remove unnecessary parens 2022-11-06 11:50:09 -05:00
Gary Gregory b9c22565fe Javadoc 2022-11-06 11:42:00 -05:00
Gary Gregory fe28f8689e PMD: AbstractReferenceMap.WeakRef implements hashCode() but not equals() 2022-11-06 11:41:40 -05:00
Gary Gregory d22eb8951b PMD: AbstractReferenceMap.SoftRef implements hashCode() but not equals() 2022-11-06 11:35:53 -05:00
Gary Gregory e84ff4dff0 PMD: No need to nest
- PMD: No need to just call super
- PMD: Simplify ternary expression to expression
- PMD: Ignore empty loop warning
- Fix import
2022-11-06 11:32:13 -05:00
Gary Gregory 5848c936b7 PMD: Use direct access 2022-11-06 11:16:28 -05:00
Gary Gregory 17db5ba533 Simplify ignorance of caught exception 2022-11-06 11:13:29 -05:00
Gary Gregory 8e300bdec2 PMD: Use direct access 2022-11-06 11:09:25 -05:00
Gary Gregory e377b46bc8 These test classes can be static 2022-11-06 10:55:42 -05:00
Gary Gregory 4033393aaf Call to super is redundant 2022-11-06 10:54:50 -05:00
Gary Gregory 62b1cc6354 Use lambdas 2022-11-06 10:52:36 -05:00
Gary Gregory 8e4c50f928 Use Java 5 for each loop 2022-11-06 10:50:43 -05:00
Gary Gregory 0801d0d4ca Simpler lambdas 2022-11-06 10:46:33 -05:00
Gary Gregory e37d375d83 Add missing @Override
Use diamonds
Use final
2022-11-06 10:42:35 -05:00
Gary Gregory 8618b108f8 Add @SuppressWarnings and tweak formatting 2022-11-06 10:18:01 -05:00
Gary Gregory 5286ebe2c6
Fix minor typos #323 2022-11-06 09:57:27 -05:00
Marc Wrobel 3a5c5c2838
(chore) Fix minor typos (#323)
Fix various minor typos in :
- project documentations,
- javadoc and comments,
- method attribute and variable names,
- test method names.
2022-11-06 09:55:27 -05:00
Claude Warren b66b6cacbb
Fixed typos originally reported in pull #323 (#349) 2022-11-06 10:56:51 +00:00
Alex Herbert 3071aea62d Bloom filter code clean-up
Correct whitespace issues.

Javadoc additions and corrections.
2022-11-05 22:31:00 +00:00
Claude Warren a251c18dae
Collections-834: Clarify Bloom filter BitCountProducer operation (#335)
Document the expected behaviour of the BitCountProducer's mapping of indices to counts.

Updated IndexProducer and BitCountProducer tests to verify the expected indices and counts; and optionally verify the encounter order is sorted and indices are distinct.
2022-11-05 21:30:47 +00:00
Alex Herbert 9a6665af36 Remove Comparable from the Shape class
The Shape could be used as a key so implements equals and hashCode. The
ordering of a Shape is arbitrary.
2022-11-05 08:43:58 +00:00
Alex Herbert f4d5690ca8 Track changes 2022-11-05 07:59:22 +00:00
anantdahiya8 14d7d98e7e
COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353) 2022-11-05 07:50:37 +00:00
aherbert 9582007123 Make Hasher test classes package-private 2022-11-04 15:40:26 +00:00
aherbert d7343b729c Remove junit-vintage-engine dependency 2022-11-04 11:25:01 +00:00
aherbert b35efc506f Remove junit version managed in commons parent via junit BOM 2022-11-04 11:09:10 +00:00
dependabot[bot] 92b7532213
Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#354)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](3cea537223...83fd05a356)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-01 14:39:43 -04:00
Gary Gregory 107fbd6c1f Bump pmd from 6.50.0 to 6.51.0 2022-10-30 11:55:27 -04:00
dependabot[bot] a3889838df Bump easymock from 5.0.0 to 5.0.1
Bumps [easymock](https://github.com/easymock/easymock) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/easymock/easymock/releases)
- [Changelog](https://github.com/easymock/easymock/blob/master/ReleaseNotes.md)
- [Commits](https://github.com/easymock/easymock/compare/easymock-5.0.0...easymock-5.0.1)

---
updated-dependencies:
- dependency-name: org.easymock:easymock
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-29 08:28:26 +13:00
Gary Gregory a868815732 Bump Scorecards from 1 to 2 2022-10-23 15:35:51 -04:00