Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,577 Commits 10 Branches 53 Tags 39 MiB
Commit Graph

2577 Commits

Author SHA1 Message Date
Sebastian Bazley 361b737752 Explicit boxing 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477740 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 17:53:55 +00:00
Sebastian Bazley 1e6dceb8cc Trailing spaces 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477739 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 17:51:06 +00:00
Sebastian Bazley bb3d861fcd Explicit boxing shows that NPE may occur so document it 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477738 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 17:50:45 +00:00
Sebastian Bazley f7f4b909d0 Unnecessary code - the null check is already done below 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477737 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 17:49:12 +00:00
Sebastian Bazley 5df60bb0e6 Trailing spaces 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477661 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 14:27:35 +00:00
Sebastian Bazley 30f5f14baa Add comment markers for remaining classes where fields could perhaps be privatised 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477647 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 14:15:54 +00:00
Sebastian Bazley c4de3dd2bb Some Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477645 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 14:14:40 +00:00
Sebastian Bazley 83119a80aa Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477629 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:44:39 +00:00
Sebastian Bazley d3aa5b7742 Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477627 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:37:36 +00:00
Sebastian Bazley d5b16405c7 Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477626 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:36:11 +00:00
Sebastian Bazley 8fe95aaec2 Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477625 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:35:22 +00:00
Sebastian Bazley b236d5259f Field can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477624 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:31:19 +00:00
Sebastian Bazley 1f5e68b561 Don't rely on direct access to internal fields 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477622 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:30:36 +00:00
Sebastian Bazley 7f0046cf4e Field can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477620 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:26:12 +00:00
Sebastian Bazley cde8451d63 Field can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477619 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:25:01 +00:00
Sebastian Bazley 8041ccfe10 Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477618 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:20:53 +00:00
Sebastian Bazley c7f3ce1ab6 Fields can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477614 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:11:28 +00:00
Sebastian Bazley b222008978 Field can be private 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477613 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:10:44 +00:00
Sebastian Bazley 35e45cc127 Privatise fields 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477612 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 13:09:57 +00:00
Sebastian Bazley 5ce18d6487 Privatise key & value; add protected setters (fields were protected) 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477599 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 12:44:12 +00:00
Sebastian Bazley 63252b4946 Use getter rather than direct access to key 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477597 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 12:43:06 +00:00
Sebastian Bazley 16d5b09656 Reduce visibility 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477522 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 09:46:50 +00:00
Sebastian Bazley 2bed7ce3f7 Privatise fields 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477521 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 09:46:12 +00:00
Thomas Neidhart 80e9621339 Do not use String.isEmpty in test class. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477518 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 09:26:31 +00:00
Thomas Neidhart c41e831722 [COLLECTIONS-456] Added additional overrides for providing an Equator, as well as for CharSequences. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477515 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 09:05:43 +00:00
Sebastian Bazley 40ad5dc2db COLLECTIONS-458 AbstractUntypedCollectionDecorator<E, D> is not used 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477514 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 09:03:12 +00:00
Thomas Neidhart 44dc835e0a [COLLECTIONS-404] Added the option to provide an Equator to test for equality, by default a DefaultEquator is used that delegates to Object.equals(). 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477512 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-30 08:57:06 +00:00
Sebastian Bazley 4fa2b6e3ac Field might as well be final 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477401 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 22:59:34 +00:00
Sebastian Bazley fcf4320023 Make fields private (and final) if possible 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477400 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 22:58:50 +00:00
Thomas Neidhart 06cec18d4a Fix typo. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477314 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 20:11:28 +00:00
Thomas Neidhart 969ffdbb98 [COLLECTIONS-456] Added ListUtils.longestCommonSubsequence(List, List). 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477312 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 20:08:46 +00:00
Thomas Neidhart 72f33c83d4 [COLLECTIONS-404] Move comparators.sequence package to top-level. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477287 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 19:26:06 +00:00
Thomas Neidhart 6594da9e36 Make field private and provide a getter. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477274 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-29 19:12:29 +00:00
Sebastian Bazley e55db317f2 Ensure oddness check works even for negative numbers 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476868 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:57:35 +00:00
Sebastian Bazley 4a64a89920 Explicit boxing 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476867 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:56:45 +00:00
Sebastian Bazley 25d443fb05 Simplify and avoid complaints about "dead store to actual" 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476864 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:43:54 +00:00
Sebastian Bazley c1be92fbfb Oops - fix up 3 instances where distint Integer instances are required 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476860 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:33:58 +00:00
Sebastian Bazley f86c69659a Don't use inefficient new Integer 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476855 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:15:54 +00:00
Sebastian Bazley 05afd18933 Simplify and avoid complaints about "dead store to actual" 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476853 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 23:09:52 +00:00
Sebastian Bazley 90634a969a Simplify and avoid complaints about "dead store to actual" 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476852 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 22:59:14 +00:00
Sebastian Bazley f2b49b393c Findbugs points out that an int can never be > Integer.MAX_VALUE 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476851 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 22:51:53 +00:00
Sebastian Bazley feb7b2fe0c No need to exactly invert whatever value is returned, especially as the Javadoc says we only return -1, 0 or +1. 
This fixes Findbugs complaint about checking compareTo with a specific value, as well as avoiding a multiplication.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476850 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 22:48:08 +00:00
Thomas Neidhart e7ae9283ba [COLLECTIONS-404] Make Snake an inner class of SequencesComparator. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476814 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 18:58:56 +00:00
Thomas Neidhart 9ea429c977 [COLLECTIONS-454] Fix findbugs warnings by returning independent Map.Entry objects from an entrySet() iterator in Flat3Map. 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476813 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 18:52:50 +00:00
Sebastian Bazley ce86f3f8aa Explicit boxing 
This documents that the boxing is actually intended, rather than an error due to the accidental use of the wrong type.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476781 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:20:56 +00:00
Sebastian Bazley 842e39bef6 Fix Javadoc syntax 
Javadoc does not seem to allow generic types, so use html entities to simulate the result
Neat hack from http://stackoverflow.com/questions/9482309/javadoc-bug-link-cant-handle-generics#comment-22244407

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476780 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:18:27 +00:00
Sebastian Bazley 22ed893d2a Javadoc syntax 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476777 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:10:37 +00:00
Sebastian Bazley 2803f385e6 Javadoc typos 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476775 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:08:15 +00:00
Sebastian Bazley 2a5a1d0d77 Missing @Override 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476773 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:03:48 +00:00
Sebastian Bazley 153f33ea77 Javadoc syntax error 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476772 13f79535-47bb-0310-9956-ffa450edef68
 2013-04-28 14:03:13 +00:00