Commit Graph

3884 Commits

Author SHA1 Message Date
Gary Gregory fe28f8689e PMD: AbstractReferenceMap.WeakRef implements hashCode() but not equals() 2022-11-06 11:41:40 -05:00
Gary Gregory d22eb8951b PMD: AbstractReferenceMap.SoftRef implements hashCode() but not equals() 2022-11-06 11:35:53 -05:00
Gary Gregory e84ff4dff0 PMD: No need to nest
- PMD: No need to just call super
- PMD: Simplify ternary expression to expression
- PMD: Ignore empty loop warning
- Fix import
2022-11-06 11:32:13 -05:00
Gary Gregory 5848c936b7 PMD: Use direct access 2022-11-06 11:16:28 -05:00
Gary Gregory 17db5ba533 Simplify ignorance of caught exception 2022-11-06 11:13:29 -05:00
Gary Gregory 8e300bdec2 PMD: Use direct access 2022-11-06 11:09:25 -05:00
Gary Gregory e377b46bc8 These test classes can be static 2022-11-06 10:55:42 -05:00
Gary Gregory 4033393aaf Call to super is redundant 2022-11-06 10:54:50 -05:00
Gary Gregory 62b1cc6354 Use lambdas 2022-11-06 10:52:36 -05:00
Gary Gregory 8e4c50f928 Use Java 5 for each loop 2022-11-06 10:50:43 -05:00
Gary Gregory 0801d0d4ca Simpler lambdas 2022-11-06 10:46:33 -05:00
Gary Gregory e37d375d83 Add missing @Override
Use diamonds
Use final
2022-11-06 10:42:35 -05:00
Gary Gregory 8618b108f8 Add @SuppressWarnings and tweak formatting 2022-11-06 10:18:01 -05:00
Gary Gregory 5286ebe2c6
Fix minor typos #323 2022-11-06 09:57:27 -05:00
Marc Wrobel 3a5c5c2838
(chore) Fix minor typos (#323)
Fix various minor typos in :
- project documentations,
- javadoc and comments,
- method attribute and variable names,
- test method names.
2022-11-06 09:55:27 -05:00
Claude Warren b66b6cacbb
Fixed typos originally reported in pull #323 (#349) 2022-11-06 10:56:51 +00:00
Alex Herbert 3071aea62d Bloom filter code clean-up
Correct whitespace issues.

Javadoc additions and corrections.
2022-11-05 22:31:00 +00:00
Claude Warren a251c18dae
Collections-834: Clarify Bloom filter BitCountProducer operation (#335)
Document the expected behaviour of the BitCountProducer's mapping of indices to counts.

Updated IndexProducer and BitCountProducer tests to verify the expected indices and counts; and optionally verify the encounter order is sorted and indices are distinct.
2022-11-05 21:30:47 +00:00
Alex Herbert 9a6665af36 Remove Comparable from the Shape class
The Shape could be used as a key so implements equals and hashCode. The
ordering of a Shape is arbitrary.
2022-11-05 08:43:58 +00:00
Alex Herbert f4d5690ca8 Track changes 2022-11-05 07:59:22 +00:00
anantdahiya8 14d7d98e7e
COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353) 2022-11-05 07:50:37 +00:00
aherbert 9582007123 Make Hasher test classes package-private 2022-11-04 15:40:26 +00:00
aherbert d7343b729c Remove junit-vintage-engine dependency 2022-11-04 11:25:01 +00:00
aherbert b35efc506f Remove junit version managed in commons parent via junit BOM 2022-11-04 11:09:10 +00:00
dependabot[bot] 92b7532213
Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#354)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](3cea537223...83fd05a356)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-01 14:39:43 -04:00
Gary Gregory 107fbd6c1f Bump pmd from 6.50.0 to 6.51.0 2022-10-30 11:55:27 -04:00
dependabot[bot] a3889838df Bump easymock from 5.0.0 to 5.0.1
Bumps [easymock](https://github.com/easymock/easymock) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/easymock/easymock/releases)
- [Changelog](https://github.com/easymock/easymock/blob/master/ReleaseNotes.md)
- [Commits](https://github.com/easymock/easymock/compare/easymock-5.0.0...easymock-5.0.1)

---
updated-dependencies:
- dependency-name: org.easymock:easymock
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-29 08:28:26 +13:00
Gary Gregory a868815732 Bump Scorecards from 1 to 2 2022-10-23 15:35:51 -04:00
Gary Gregory dca05e593e
Bump easymock from 4.3 to 5.0.0 #352 2022-10-21 08:30:37 -04:00
dependabot[bot] 96fde99371
Bump easymock from 4.3 to 5.0.0 (#352)
Bumps [easymock](https://github.com/easymock/easymock) from 4.3 to 5.0.0.
- [Release notes](https://github.com/easymock/easymock/releases)
- [Changelog](https://github.com/easymock/easymock/blob/master/ReleaseNotes.md)
- [Commits](https://github.com/easymock/easymock/compare/easymock-4.3...easymock-5.0.0)

---
updated-dependencies:
- dependency-name: org.easymock:easymock
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-21 08:29:33 -04:00
dependabot[bot] ccc57821e9 Bump actions/setup-java from 3.5.1 to 3.6.0
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v3.5.1...v3.6.0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-22 01:19:33 +13:00
Bruno P. Kinoshita 304a1bf3f3 Merge branch 'pr-340'
This closes #340
2022-10-19 15:09:53 +13:00
Bruno P. Kinoshita 8c91a51546 [COLLECTIONS-814] Add change log 2022-10-19 15:09:21 +13:00
Angus 17bed2b555 [COLLECTIONS-814] CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
Add null check
2022-10-19 15:07:20 +13:00
Bruno P. Kinoshita 06cc4554b5 Merge branch 'pr-325'
This closes #325
2022-10-19 14:08:20 +13:00
Bruno P. Kinoshita 463d2cc57b [COLLECTIONS-835] Add change log and credit 2022-10-19 14:08:05 +13:00
Marc Wrobel 297f7af4af [COLLECTIONS-835] Fix links in javadoc and documentations
- fix broken links,
- use direct links instead of redirects,
- use HTTPS where possible.
2022-10-19 14:07:20 +13:00
dependabot[bot] c4016fe938
Bump actions/cache from 3.0.10 to 3.0.11 (#348)
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.10 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.10...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-14 13:18:41 -04:00
Sebb 3c75a1d08c Don't persist credentials unnecessarily 2022-10-08 15:14:48 +01:00
Gary Gregory 4a398f54ae Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2022-10-07 20:04:19 -04:00
Gary Gregory 6033c9d66f Set to level permissions to 'read' 2022-10-07 20:04:11 -04:00
dependabot[bot] 3187cc0575 Bump actions/checkout from 3.0.2 to 3.1.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.0.2...93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 11:10:56 +13:00
dependabot[bot] e1dd9678e9 Bump commons.pmd-impl.version from 6.49.0 to 6.50.0
Bumps `commons.pmd-impl.version` from 6.49.0 to 6.50.0.

Updates `pmd-core` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-java` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-javascript` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-jsp` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

---
updated-dependencies:
- dependency-name: net.sourceforge.pmd:pmd-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-javascript
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-jsp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 10:58:27 +13:00
dependabot[bot] 2ebb950848 Bump actions/cache from 3.0.9 to 3.0.10
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.9 to 3.0.10.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.9...v3.0.10)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 10:56:13 +13:00
Gary Gregory c5649f4d64 GitHub Actions build: no top level permission defined 2022-10-06 18:36:29 -04:00
Partha Protim Paul 28c74518bc
Fix flaky test failure in 'AbstractCollectionTest.testCollectionToArray2'
Use the AbstractCollectionTest iteration order flag in Map and Bag tests. These tests have inner classes that extend AbstractCollectionTest to test their values collection. This should be robust to an unspecified iteration order.
2022-10-03 11:12:38 +01:00
Gary Gregory 917cdf1bf8 Bump actions/setup-java from 3 to 3.5.1 2022-10-01 14:32:15 -04:00
Gary Gregory 88844fdbdf
Bump actions/cache from 3.0.8 to 3.0.9 #342 2022-09-30 09:40:09 -04:00
dependabot[bot] ec55b1adf1
Bump actions/cache from 3.0.8 to 3.0.9 (#342)
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.8 to 3.0.9.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.8...v3.0.9)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-30 09:39:15 -04:00
Gary Gregory 983e1824a1 Replace Travis-CI badge with GitHub Actions CI 2022-09-29 14:29:28 -04:00