Commit Graph

2637 Commits

Author SHA1 Message Date
Sebastian Bazley f2b49b393c Findbugs points out that an int can never be > Integer.MAX_VALUE
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476851 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 22:51:53 +00:00
Sebastian Bazley feb7b2fe0c No need to exactly invert whatever value is returned, especially as the Javadoc says we only return -1, 0 or +1.
This fixes Findbugs complaint about checking compareTo with a specific value, as well as avoiding a multiplication.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476850 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 22:48:08 +00:00
Thomas Neidhart e7ae9283ba [COLLECTIONS-404] Make Snake an inner class of SequencesComparator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476814 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 18:58:56 +00:00
Thomas Neidhart 9ea429c977 [COLLECTIONS-454] Fix findbugs warnings by returning independent Map.Entry objects from an entrySet() iterator in Flat3Map.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476813 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 18:52:50 +00:00
Sebastian Bazley ce86f3f8aa Explicit boxing
This documents that the boxing is actually intended, rather than an error due to the accidental use of the wrong type.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476781 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:20:56 +00:00
Sebastian Bazley 842e39bef6 Fix Javadoc syntax
Javadoc does not seem to allow generic types, so use html entities to simulate the result
Neat hack from http://stackoverflow.com/questions/9482309/javadoc-bug-link-cant-handle-generics#comment-22244407

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476780 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:18:27 +00:00
Sebastian Bazley 22ed893d2a Javadoc syntax
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476777 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:10:37 +00:00
Sebastian Bazley 2803f385e6 Javadoc typos
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476775 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:08:15 +00:00
Sebastian Bazley 2a5a1d0d77 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476773 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:03:48 +00:00
Sebastian Bazley 153f33ea77 Javadoc syntax error
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476772 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:03:13 +00:00
Thomas Neidhart c71a9e8c2b [COLLECTIONS-296] Renamed CollectionUtils.merge to collate, simplify implementation by using a CollatingIterator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476770 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 13:58:37 +00:00
Thomas Neidhart 696c768716 Added more issues which were marked with fix version 4.0-beta1, applied one pending fix for using Arrays.toString.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476681 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 21:48:13 +00:00
Thomas Neidhart 1377fa84d7 Fix javadoc links and code examples.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476599 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 15:12:42 +00:00
Thomas Neidhart 790c5068f7 Fix jira-report, snippet taken from commons-math.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476594 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:45:34 +00:00
Thomas Neidhart 047b8fb527 ignore false-positive from pmd
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476593 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:44:48 +00:00
Thomas Neidhart bca5b3c0ff Fix PMD warnings.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476589 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:35:38 +00:00
Thomas Neidhart cca574ea06 Replace references to getInstance with the corresponding factory method name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476582 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:13:54 +00:00
Thomas Neidhart fad4f969df Make DefaultEquator a singleton, hide default ctor.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476578 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:02:30 +00:00
Thomas Neidhart bac0bd081e Add findbugs exclude filters for ObjectArrayIterator and UnmodifiableBidiMap.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476564 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 12:40:02 +00:00
Thomas Neidhart d574dffb1f Make DefaultEquator serializable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476558 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 12:08:19 +00:00
Thomas Neidhart 803a9c6c17 [COLLECTIONS-310] SetUniqueList#subList now returns an unmodifiable list.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476557 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:57:01 +00:00
Thomas Neidhart 4b9c68b55a Reordered tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476555 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:23:06 +00:00
Thomas Neidhart c9e1e5c8f5 [COLLECTIONS-237] Added MultiValueMap.iterator() and clarified javadoc for entrySet().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476553 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:08:26 +00:00
Thomas Neidhart 50bd9f108b Added missing since tags
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476507 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 07:16:48 +00:00
Thomas Neidhart 8641a2e3d5 Added TODO for AbstractQueueTest.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475976 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:39:12 +00:00
Thomas Neidhart 8157a72408 Added an AbstractQueueTest as base class for all queue tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475974 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:37:18 +00:00
Thomas Neidhart 0f32e037b9 classes have been renamed.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475957 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:03:52 +00:00
Thomas Neidhart 7d2532b86b Enable serialization tests for bags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475955 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:56:05 +00:00
Thomas Neidhart 0c05822544 Reorder tests, remove TODO as it should be fine imho.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475953 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:48:08 +00:00
Thomas Neidhart 766d9add03 [COLLECTIONS-263] Added MapUtils#populateMap(MultiMap, ...) methods.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475949 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:38:58 +00:00
Thomas Neidhart b591dacd5c Fix some generics warnings in test classes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475940 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:09:15 +00:00
Thomas Neidhart cb3b31ed23 [COLLECTIONS-450] Added CollectionUtils.forAllButLastDo(...) methods. Thanks to J. Moldawski
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475937 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:02:15 +00:00
Thomas Neidhart f7c4d60cda Finished adding all changes, cant believe it ...
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1471125 13f79535-47bb-0310-9956-ffa450edef68
2013-04-23 20:02:43 +00:00
Thomas Neidhart 5663fe652a Format change entry.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470721 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:17:31 +00:00
Thomas Neidhart 100be78228 Added missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470720 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:10:55 +00:00
Thomas Neidhart 59d2633770 findbugs: add constructor that sets the member field, but may remove class as it is unused.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470719 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:06:45 +00:00
Thomas Neidhart c429128e8f ExtendedProperties has already been removed.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470714 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 20:58:20 +00:00
Thomas Neidhart ea15ac123a More changelog entries.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470713 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 20:54:41 +00:00
Thomas Neidhart 19c429783a More change entries, sorting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470702 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 20:24:42 +00:00
Thomas Neidhart 0751f75c4c Added more changelog entries from JIRA.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470688 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 19:57:58 +00:00
Sebastian Bazley 6d1945c8ed Simplify
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470346 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 21:03:39 +00:00
Sebastian Bazley b555f1d127 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470345 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 21:01:35 +00:00
Sebastian Bazley 724fa9400f Fix raw type
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470344 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:59:57 +00:00
Sebastian Bazley a183825420 Javadoc typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470343 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:43:00 +00:00
Sebastian Bazley eaa218844a Unnecessary suppresswarnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470342 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:42:30 +00:00
Sebastian Bazley 461141c88b The classes have serial ids; no need to suppress the warning
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470341 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:41:15 +00:00
Sebastian Bazley 212ac51aee Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470340 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:40:32 +00:00
Sebastian Bazley 1df5607ba7 The classes have serial ids; no need to suppress the warning
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470339 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:28:58 +00:00
Thomas Neidhart afae3dd81d Update javadoc with renamed tests, minor formatting fixes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470324 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 17:55:14 +00:00
Thomas Neidhart 3058d1865c Comment tests which create the serialization files.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470323 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 17:51:33 +00:00