Commit Graph

2542 Commits

Author SHA1 Message Date
Sebastian Bazley 5d83e4deb8 Add some tests for toString
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477781 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:09:01 +00:00
Thomas Neidhart b7430de759 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477779 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:55:24 +00:00
Sebastian Bazley 0ba5e75432 Ensure switch statements have defaults; ensure IllegalStateException messages include the index value
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477774 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:48:14 +00:00
Thomas Neidhart b979fd11e1 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477772 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:44:21 +00:00
Thomas Neidhart eef240cfdf Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477765 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:37:37 +00:00
Thomas Neidhart 6ee118d2a1 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477763 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:35:29 +00:00
Thomas Neidhart 274aa78fcd Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477760 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:34:03 +00:00
Thomas Neidhart d6b40fdbe9 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477756 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:31:13 +00:00
Thomas Neidhart 315b0c786f Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477753 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:24:24 +00:00
Thomas Neidhart 7d9196da0e Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477752 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:21:52 +00:00
Thomas Neidhart 53cf9ed7f6 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477747 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:16:48 +00:00
Thomas Neidhart 3b9d20636a Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477746 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:11:20 +00:00
Thomas Neidhart 75e7e31108 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477745 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:08:32 +00:00
Thomas Neidhart 2565d09502 Add trailing whitespace checkstyle rule.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477744 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:03:28 +00:00
Sebastian Bazley 9a2f53d2d5 Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477741 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:58:35 +00:00
Sebastian Bazley 361b737752 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477740 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:53:55 +00:00
Sebastian Bazley 1e6dceb8cc Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477739 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:51:06 +00:00
Sebastian Bazley bb3d861fcd Explicit boxing shows that NPE may occur so document it
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477738 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:50:45 +00:00
Sebastian Bazley f7f4b909d0 Unnecessary code - the null check is already done below
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477737 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:49:12 +00:00
Sebastian Bazley 5df60bb0e6 Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477661 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:27:35 +00:00
Sebastian Bazley 30f5f14baa Add comment markers for remaining classes where fields could perhaps be privatised
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477647 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:15:54 +00:00
Sebastian Bazley c4de3dd2bb Some Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477645 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:14:40 +00:00
Sebastian Bazley 83119a80aa Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477629 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:44:39 +00:00
Sebastian Bazley d3aa5b7742 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477627 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:37:36 +00:00
Sebastian Bazley d5b16405c7 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477626 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:36:11 +00:00
Sebastian Bazley 8fe95aaec2 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477625 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:35:22 +00:00
Sebastian Bazley b236d5259f Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477624 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:31:19 +00:00
Sebastian Bazley 1f5e68b561 Don't rely on direct access to internal fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477622 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:30:36 +00:00
Sebastian Bazley 7f0046cf4e Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477620 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:26:12 +00:00
Sebastian Bazley cde8451d63 Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477619 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:25:01 +00:00
Sebastian Bazley 8041ccfe10 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477618 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:20:53 +00:00
Sebastian Bazley c7f3ce1ab6 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477614 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:11:28 +00:00
Sebastian Bazley b222008978 Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477613 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:10:44 +00:00
Sebastian Bazley 35e45cc127 Privatise fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477612 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:09:57 +00:00
Sebastian Bazley 5ce18d6487 Privatise key & value; add protected setters (fields were protected)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477599 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 12:44:12 +00:00
Sebastian Bazley 63252b4946 Use getter rather than direct access to key
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477597 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 12:43:06 +00:00
Sebastian Bazley 16d5b09656 Reduce visibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477522 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:46:50 +00:00
Sebastian Bazley 2bed7ce3f7 Privatise fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477521 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:46:12 +00:00
Thomas Neidhart 80e9621339 Do not use String.isEmpty in test class.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477518 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:26:31 +00:00
Thomas Neidhart c41e831722 [COLLECTIONS-456] Added additional overrides for providing an Equator, as well as for CharSequences.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477515 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:05:43 +00:00
Sebastian Bazley 40ad5dc2db COLLECTIONS-458 AbstractUntypedCollectionDecorator<E, D> is not used
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477514 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:03:12 +00:00
Thomas Neidhart 44dc835e0a [COLLECTIONS-404] Added the option to provide an Equator to test for equality, by default a DefaultEquator is used that delegates to Object.equals().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477512 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 08:57:06 +00:00
Sebastian Bazley 4fa2b6e3ac Field might as well be final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477401 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 22:59:34 +00:00
Sebastian Bazley fcf4320023 Make fields private (and final) if possible
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477400 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 22:58:50 +00:00
Thomas Neidhart 06cec18d4a Fix typo.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477314 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 20:11:28 +00:00
Thomas Neidhart 969ffdbb98 [COLLECTIONS-456] Added ListUtils.longestCommonSubsequence(List, List).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477312 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 20:08:46 +00:00
Thomas Neidhart 72f33c83d4 [COLLECTIONS-404] Move comparators.sequence package to top-level.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477287 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 19:26:06 +00:00
Thomas Neidhart 6594da9e36 Make field private and provide a getter.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477274 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 19:12:29 +00:00
Sebastian Bazley e55db317f2 Ensure oddness check works even for negative numbers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476868 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:57:35 +00:00
Sebastian Bazley 4a64a89920 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476867 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:56:45 +00:00