Apache
/
commons-csv
mirror of https://github.com/apache/commons-csv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add @SuppressWarnings("resource") in test as narrowly as possible

This commit is contained in:
Gary Gregory 2022-10-26 10:12:58 -04:00
parent dab9420315
commit 236b0f4f84
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/java/org/apache/commons/csv/CSVParserTest.java
View File

@ -905,8 +905,10 @@ public class CSVParserTest {
final Iterator<CSVRecord> records = parser.iterator(); final Iterator<CSVRecord> records = parser.iterator();
final CSVRecord record = records.next(); final CSVRecord record = records.next();
// Expect the null header to be missing // Expect the null header to be missing
assertEquals(Arrays.asList("header1", "header3"), record.getParser().getHeaderNames()); @SuppressWarnings("resource")
assertEquals(2, record.getParser().getHeaderMap().size()); final CSVParser recordParser = record.getParser();
assertEquals(Arrays.asList("header1", "header3"), recordParser.getHeaderNames());
assertEquals(2, recordParser.getHeaderMap().size());
} }
} }
@ -1132,7 +1134,8 @@ public class CSVParserTest {
final CSVFormat format = CSVFormat.DEFAULT.withHeader("A", "B", "C", "D"); final CSVFormat format = CSVFormat.DEFAULT.withHeader("A", "B", "C", "D");
final Charset charset = StandardCharsets.UTF_8; final Charset charset = StandardCharsets.UTF_8;
try (final CSVParser parser = CSVParser.parse(new InputStreamReader(url.openStream(), charset), format)) { try (@SuppressWarnings("resource") // CSVParser closes the input resource
final CSVParser parser = CSVParser.parse(new InputStreamReader(url.openStream(), charset), format)) {
parseFully(parser); parseFully(parser);
} }
try (final CSVParser parser = CSVParser.parse(new String(Files.readAllBytes(Paths.get(url.toURI())), charset), format)) { try (final CSVParser parser = CSVParser.parse(new String(Files.readAllBytes(Paths.get(url.toURI())), charset), format)) {
@ -1141,7 +1144,8 @@ public class CSVParserTest {
try (final CSVParser parser = CSVParser.parse(new File(url.toURI()), charset, format)) { try (final CSVParser parser = CSVParser.parse(new File(url.toURI()), charset, format)) {
parseFully(parser); parseFully(parser);
} }
try (final CSVParser parser = CSVParser.parse(url.openStream(), charset, format)) { try (@SuppressWarnings("resource") // CSVParser closes the input resource
final CSVParser parser = CSVParser.parse(url.openStream(), charset, format)) {
parseFully(parser); parseFully(parser);
} }
try (final CSVParser parser = CSVParser.parse(Paths.get(url.toURI()), charset, format)) { try (final CSVParser parser = CSVParser.parse(Paths.get(url.toURI()), charset, format)) {
@ -1313,7 +1317,9 @@ public class CSVParserTest {
try (final CSVParser parser = CSVFormat.DEFAULT.withFirstRecordAsHeader().withTrim().parse(in)) { try (final CSVParser parser = CSVFormat.DEFAULT.withFirstRecordAsHeader().withTrim().parse(in)) {
final Iterator<CSVRecord> records = parser.iterator(); final Iterator<CSVRecord> records = parser.iterator();
final CSVRecord record = records.next(); final CSVRecord record = records.next();
assertEquals(Arrays.asList("header1", "header2", "header1"), record.getParser().getHeaderNames()); @SuppressWarnings("resource")
final CSVParser recordParser = record.getParser();
assertEquals(Arrays.asList("header1", "header2", "header1"), recordParser.getHeaderNames());
}} }}
@Test @Test