Apache
/
commons-csv
mirror of https://github.com/apache/commons-csv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CSV-244 Test case failures following CSVFormat#equals() update

This commit is contained in:
Sebb 2019-06-15 14:29:30 +01:00
parent 0279beaba0
commit 42b9fdb099
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/changes/changes.xml
View File

@ -39,6 +39,7 @@
</properties> </properties>
<body> <body>
<release version="1.8" date="2019-MM-DD" description="Feature and bug fix release (Java 8)"> <release version="1.8" date="2019-MM-DD" description="Feature and bug fix release (Java 8)">
<action issue="CSV-244" type="fix" dev="sebb">Test case failures following CSVFormat#equals() update.</action>
<action issue="CSV-243" type="fix" dev="sebb">CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs.</action> <action issue="CSV-243" type="fix" dev="sebb">CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs.</action>
<action issue="CSV-242" type="fix" dev="sebb">CSVFormat equals() and hashCode() don't use all fields.</action> <action issue="CSV-242" type="fix" dev="sebb">CSVFormat equals() and hashCode() don't use all fields.</action>
<action issue="CSV-241" type="fix" dev="ggregory" due-to="LuckyIlam, Gary Gregory">CSVFormat#valiadte() does not account for allowDuplicateHeaderNames #43.</action> <action issue="CSV-241" type="fix" dev="ggregory" due-to="LuckyIlam, Gary Gregory">CSVFormat#valiadte() does not account for allowDuplicateHeaderNames #43.</action>

11
src/test/java/org/apache/commons/csv/CSVFormatTest.java
View File

@ -517,10 +517,11 @@ public class CSVFormatTest {
final CSVFormat csvFormatTwo = csvFormat.withIgnoreHeaderCase(); final CSVFormat csvFormatTwo = csvFormat.withIgnoreHeaderCase();
csvFormatTwo.hashCode(); csvFormatTwo.hashCode();
assertTrue(csvFormatTwo.getIgnoreHeaderCase()); assertFalse(csvFormat.getIgnoreHeaderCase());
assertTrue(csvFormatTwo.getIgnoreHeaderCase()); // now different
assertFalse(csvFormatTwo.getTrailingDelimiter()); assertFalse(csvFormatTwo.getTrailingDelimiter());
assertTrue(csvFormatTwo.equals(csvFormat)); // TODO this fails since CSV-242 was applied. Why should they compare equal? assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
assertFalse(csvFormatTwo.getAllowMissingColumnNames()); assertFalse(csvFormatTwo.getAllowMissingColumnNames());
assertFalse(csvFormatTwo.getTrim()); assertFalse(csvFormatTwo.getTrim());
@ -969,7 +970,7 @@ public class CSVFormatTest {
assertNotSame(csvFormat, csvFormatTwo); assertNotSame(csvFormat, csvFormatTwo);
assertNotSame(csvFormatTwo, csvFormat); assertNotSame(csvFormatTwo, csvFormat);
assertTrue(csvFormatTwo.equals(csvFormat)); // TODO this fails since CSV-242 was applied. Why should the formats compare equal? assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
final String string = csvFormatTwo.format(objectArray); final String string = csvFormatTwo.format(objectArray);
@ -1031,9 +1032,9 @@ public class CSVFormatTest {
assertNotSame(csvFormatTwo, csvFormat); assertNotSame(csvFormatTwo, csvFormat);
assertNotNull(string); assertNotNull(string);
assertTrue(csvFormat.equals(csvFormatTwo)); assertFalse(csvFormat.equals(csvFormatTwo)); // CSV-244 - should not be equal
assertTrue(csvFormatTwo.equals(csvFormat)); assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
assertEquals(",,,,,,,", string); assertEquals(",,,,,,,", string);
} }