Apache
/
commons-csv
mirror of https://github.com/apache/commons-csv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Convert new test into a proper JUnit test

This commit is contained in:
Gary Gregory 2024-04-06 08:27:37 -04:00
parent 4224a3289c
commit 70c9418e71
1 changed files with 16 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/test/java/org/apache/commons/csv/CSVParserTest.java
View File

@ -50,12 +50,17 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.NoSuchElementException; import java.util.NoSuchElementException;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.commons.io.input.BOMInputStream; import org.apache.commons.io.input.BOMInputStream;
import org.apache.commons.io.input.BrokenInputStream; import org.apache.commons.io.input.BrokenInputStream;
import org.apache.commons.lang3.stream.Streams.FailableStream;
import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;
import org.junit.jupiter.params.provider.ValueSource;
/** /**
* CSVParserTest * CSVParserTest
@ -1380,36 +1385,19 @@ public class CSVParserTest {
} }
} }
@Test @ParameterizedTest
public void testParsingPrintedEmptyFirstColumn() throws Exception { @EnumSource(CSVFormat.Predefined.class)
public void testParsingPrintedEmptyFirstColumn(final CSVFormat.Predefined format) throws Exception {
final String[][] lines = { { "a", "b" }, { "", "x" } }; final String[][] lines = { { "a", "b" }, { "", "x" } };
Exception firstException = null;
for (final CSVFormat.Predefined format : CSVFormat.Predefined.values()) {
try {
final StringWriter buf = new StringWriter(); final StringWriter buf = new StringWriter();
try (CSVPrinter printer = new CSVPrinter(buf, format.getFormat())) { try (CSVPrinter printer = new CSVPrinter(buf, format.getFormat())) {
printer.printRecords(Stream.of(lines));
}
try (CSVParser parser = new CSVParser(new StringReader(buf.toString()), format.getFormat())) {
for (final String[] line : lines) { for (final String[] line : lines) {
printer.printRecord((Object[]) line); assertArrayEquals(line, parser.nextRecord().values());
} }
} assertNull(parser.nextRecord());
try (CSVParser csvRecords = new CSVParser(new StringReader(buf.toString()), format.getFormat())) {
for (final String[] line : lines) {
assertArrayEquals(line, csvRecords.nextRecord().values());
}
assertNull(csvRecords.nextRecord());
}
} catch (Exception | Error e) {
final Exception detailedException = new RuntimeException("format: " + format, e);
if (firstException == null) {
firstException = detailedException;
} else {
firstException.addSuppressed(detailedException);
}
}
}
if (firstException != null) {
throw firstException;
} }
} }