From b3daff2323172cac47f91683c04b0edf8f14a048 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Fri, 9 Jul 2021 11:22:15 -0400 Subject: [PATCH] Better resource management. --- .../org/apache/commons/csv/issues/JiraCsv247Test.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java index a3a7f8fc..4dc18a00 100644 --- a/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java +++ b/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java @@ -67,14 +67,16 @@ public class JiraCsv247Test { assertFalse(format.getAllowMissingColumnNames(), "By default we should not allow missing column names"); assertThrows(IllegalArgumentException.class, () -> { - try (final Reader in = new StringReader("a,,c,d,e\n1,2,3,4,5\nv,w,x,y,z")) { - format.parse(in); + try (final Reader reader = new StringReader("a,,c,d,e\n1,2,3,4,5\nv,w,x,y,z"); + CSVParser parser = format.parse(reader);) { + // should fail } }, "1 missing column header is not allowed"); assertThrows(IllegalArgumentException.class, () -> { - try (final Reader in = new StringReader("a,,c,d,\n1,2,3,4,5\nv,w,x,y,z")) { - format.parse(in); + try (final Reader reader = new StringReader("a,,c,d,\n1,2,3,4,5\nv,w,x,y,z"); + CSVParser parser = format.parse(reader);) { + // should fail } }, "2+ missing column headers is not allowed!"); }