Apache
/
commons-csv
mirror of https://github.com/apache/commons-csv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CSV-242 CSVFormat equals() and hashCode() don't use all fields 

Fix hashCode()
This commit is contained in:
Sebb 2019-06-14 17:21:33 +01:00
parent 46c84341e6
commit c683594f59
3 changed files with 192 additions and 182 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/changes/changes.xml
View File

@ -39,6 +39,7 @@
</properties>
<body>
<release version="1.8" date="2019-MM-DD" description="Feature and bug fix release (Java 8)">
<action issue="CSV-242" type="fix" dev="sebb">CSVFormat equals() and hash() don't use all fields</action>
<action issue="CSV-241" type="fix" dev="ggregory" due-to="LuckyIlam, Gary Gregory">CSVFormat#valiadte() does not account for allowDuplicateHeaderNames #43.</action>
</release>
<release version="1.7" date="2019-06-01" description="Feature and bug fix release (Java 8)">

6
src/main/java/org/apache/commons/csv/CSVFormat.java
View File

@ -1089,8 +1089,14 @@ public final class CSVFormat implements Serializable {
result = prime * result + (ignoreHeaderCase ? 1231 : 1237);
result = prime * result + (ignoreEmptyLines ? 1231 : 1237);
result = prime * result + (skipHeaderRecord ? 1231 : 1237);
result = prime * result + (allowDuplicateHeaderNames ? 1231 : 1237);
result = prime * result + (trim ? 1231 : 1237);
result = prime * result + (autoFlush ? 1231 : 1237);
result = prime * result + (trailingDelimiter ? 1231 : 1237);
result = prime * result + (allowMissingColumnNames ? 1231 : 1237);
result = prime * result + ((recordSeparator == null) ? 0 : recordSeparator.hashCode());
result = prime * result + Arrays.hashCode(header);
result = prime * result + Arrays.hashCode(headerComments);
return result;
}

5
src/test/java/org/apache/commons/csv/CSVFormatTest.java
View File

@ -1112,7 +1112,10 @@ public class CSVFormatTest {
private void assertNotEquals(String name, String type, Object left, Object right) {
if (left.equals(right) || right.equals(left)) {
System.out.println("Should not be equal for " + name + "(" + type + ")");
fail("Objects must not compare equal for " + name + "(" + type + ")");
}
if (left.hashCode() == right.hashCode()) {
fail("Hash code not be equal for " + name + "(" + type + ")");
}
}