1162 Commits

Author SHA1 Message Date
Gary D. Gregory
d5cc0d8a7c Replace magic String with constant from Constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495912 13f79535-47bb-0310-9956-ffa450edef68
2013-06-24 03:17:29 +00:00
Gary D. Gregory
5a0894f9e0 [CSV-93] Allow the handling of NULL values. Use a single property 'nullString' for both input and output processing. No substitutions occur if null. For reading, nullString is used to convert field values to null. For writing, nullString is used to output the given string instead of the empty string.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495911 13f79535-47bb-0310-9956-ffa450edef68
2013-06-24 03:06:05 +00:00
Gary D. Gregory
530b038269 Fix possible NPE reported by FindBugs.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495269 13f79535-47bb-0310-9956-ffa450edef68
2013-06-21 01:49:03 +00:00
Gary D. Gregory
93a07b9b8f Better param name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495268 13f79535-47bb-0310-9956-ffa450edef68
2013-06-21 01:46:26 +00:00
Gary D. Gregory
30579102f6 Update H2 used for tests to 1.3.172 from 1.3.168.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495264 13f79535-47bb-0310-9956-ffa450edef68
2013-06-21 01:23:30 +00:00
Gary D. Gregory
ab2e7eb504 - Add final modifier to method parameters.
- Add final modifier to local variables.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1495203 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 21:39:53 +00:00
Benedikt Ritter
4aa1f4d36c Update to latest commons parent pom
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1491178 13f79535-47bb-0310-9956-ffa450edef68
2013-06-09 10:25:50 +00:00
Benedikt Ritter
8fc8386db0 Use viewvc instead of raw svn url
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1491175 13f79535-47bb-0310-9956-ffa450edef68
2013-06-09 10:18:42 +00:00
Sebastian Bazley
006188ebb9 Allow checkstyle to be run interactively (not part of site build)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1485830 13f79535-47bb-0310-9956-ffa450edef68
2013-05-23 19:15:59 +00:00
Sebastian Bazley
c6c762ad9d Checkstyle: put trailing || on previous line (indicates more to come)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1485805 13f79535-47bb-0310-9956-ffa450edef68
2013-05-23 18:21:32 +00:00
Sebastian Bazley
e5d7b21456 Checkstyle: trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1485799 13f79535-47bb-0310-9956-ffa450edef68
2013-05-23 18:17:23 +00:00
Sebastian Bazley
67b778e455 Document how to avoid the following site build failure
Embedded error: Error rendering Maven report: org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1485623 13f79535-47bb-0310-9956-ffa450edef68
2013-05-23 09:27:17 +00:00
Sebastian Bazley
abdad63c89 Missing issueManagement section added
Renamed deprecated tag

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1485520 13f79535-47bb-0310-9956-ffa450edef68
2013-05-23 00:34:02 +00:00
Sebastian Bazley
512e446d28 Add code and test for Quote.NONE
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1480499 13f79535-47bb-0310-9956-ffa450edef68
2013-05-08 23:54:22 +00:00
Sebastian Bazley
bb3bb0d65b Test default Quote policy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1480498 13f79535-47bb-0310-9956-ffa450edef68
2013-05-08 23:43:14 +00:00
Sebastian Bazley
71c69df6dd CSV-98 Line number counting is confusing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479936 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 15:12:48 +00:00
Sebastian Bazley
5b2e5f809b Simplify code so delimiter only printed in one place
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479823 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 09:09:11 +00:00
Sebastian Bazley
978e5796e2 MOre tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479753 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 02:21:38 +00:00
Sebastian Bazley
0fabee5f24 Add some more tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479730 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:54:45 +00:00
Sebastian Bazley
02c1b35939 Document why original object is needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479721 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:29:45 +00:00
Sebastian Bazley
c616a17650 Typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479719 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:24:07 +00:00
Sebastian Bazley
e697318e68 Fix Javadoc to current behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479712 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 23:02:34 +00:00
Sebastian Bazley
4f61bd1aee Extract check for metaChar
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479706 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 22:38:23 +00:00
Sebastian Bazley
883511fa42 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1479701 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 22:18:21 +00:00
Benedikt Ritter
e6ba150743 Use isDelimiter method instead of != check.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478655 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 06:37:58 +00:00
Sebastian Bazley
2c61208262 CSV-58 Unescape handling needs rethinking
Fixed up most issues.
TODO should TAB, FF and BACKSPACE be un/escaped?

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478621 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 01:10:34 +00:00
Sebastian Bazley
e31980892c Bug in test case result
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1478619 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 01:01:20 +00:00
Gary D. Gregory
697a612a89 Remove unused import.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1469437 13f79535-47bb-0310-9956-ffa450edef68
2013-04-18 16:59:44 +00:00
Sebastian Bazley
6640e8597c Standardise on record rather than line; fix incorrect Javadoc comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1468827 13f79535-47bb-0310-9956-ffa450edef68
2013-04-17 10:31:57 +00:00
Sebastian Bazley
939a8a04eb Standardise on recordSeparator; fix incorrect Javadoc comments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1468825 13f79535-47bb-0310-9956-ffa450edef68
2013-04-17 10:28:33 +00:00
Benedikt Ritter
f16818b3ba Give tests a better name that expresses, what actually happens
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467766 13f79535-47bb-0310-9956-ffa450edef68
2013-04-14 11:35:47 +00:00
Benedikt Ritter
04522fbf90 Change JavaDoc to match actual parameter name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467666 13f79535-47bb-0310-9956-ffa450edef68
2013-04-13 17:55:16 +00:00
Benedikt Ritter
03fefe8c30 Add missing JavaDoc for parameter
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1467665 13f79535-47bb-0310-9956-ffa450edef68
2013-04-13 17:49:37 +00:00
Benedikt Ritter
7e9b381a6f Document expected result for ignored test
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466605 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:16:23 +00:00
Benedikt Ritter
16e12d2130 Change wrong input data of test. Test now fails because of CSV-58 and is therefore changed to be @Ignore.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466604 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:15:36 +00:00
Benedikt Ritter
fd8433b711 Give test a better name and remove comment that is now no longer needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466601 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 18:05:31 +00:00
Benedikt Ritter
6c346b143a Give test a better name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466591 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 17:48:28 +00:00
Benedikt Ritter
b05af3c049 Add a test that makes sure ignoreSurroundingWhitespaces works for the tab character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466590 13f79535-47bb-0310-9956-ffa450edef68
2013-04-10 17:47:42 +00:00
Gary D. Gregory
a7e4484db9 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1466223 13f79535-47bb-0310-9956-ffa450edef68
2013-04-09 20:43:29 +00:00
Gary D. Gregory
f57afe607e Fix checksyle trailing space.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465774 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:41:29 +00:00
Gary D. Gregory
e9e52dfaca Use 2.9.1 instead of 2.10; 2.10 seems to scan the 'target' dir and wants license headers in .properties to be the header for Java files.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465773 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:40:45 +00:00
Gary D. Gregory
75b9a4ba4e [CSV-97] Allow the String value for null to be customized for the CSV printer.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465768 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:34:49 +00:00
Gary D. Gregory
60cc83af7f Sort members, classes and methods (but not fields).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465763 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 20:23:57 +00:00
Gary D. Gregory
afc9de71bd Better parameter name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465753 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:57:32 +00:00
Benedikt Ritter
a0d975933d [CSV-96] CSVRecord does not verify that the length of the header mapping matches the number of values - convert ArrayIndexOutOfBoundsException to IllegalArgumentException to give users a better feedback about what went wrong
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465738 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 19:34:38 +00:00
Benedikt Ritter
5744ee8a16 Separate testing empty line handling from comment recognition
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465722 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:55:58 +00:00
Benedikt Ritter
449e9a8cf6 Make sure empty lines are ignored by constructing CSVFormat this way. Remove corresponding assert that would have failed if CSVFormat.newBuilder() was changed to withIgnoreEmptyLines(false)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465718 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:37:22 +00:00
Benedikt Ritter
19cb2ca2eb Give test a name that's a bit more expressive and remove comment that is no longer needed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465715 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:33:36 +00:00
Benedikt Ritter
7c4121b5e0 Remove comment, intention of test is now expressed in its name
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465709 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:27:34 +00:00
Benedikt Ritter
4c8024fb76 Express intention of tokens in token content and give test more structure
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1465705 13f79535-47bb-0310-9956-ffa450edef68
2013-04-08 18:23:32 +00:00