Commit Graph

785 Commits

Author SHA1 Message Date
Benedikt Ritter 4213415b2c Don't make JavaDoc references from production code to test code
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512618 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:49:30 +00:00
Benedikt Ritter 04a2e9ebe4 Remove unused method. It made no sense anyway, since Assert.assertArrayEquals is capable of comparing multi dimensional arrays.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512617 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:46:03 +00:00
Benedikt Ritter 8b74f0aaff Utils class is only used for internal testing, it can be package private. Also make it final since it should not be extended.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512615 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:41:27 +00:00
Benedikt Ritter 06630f4b4b Make members private, they are only needed in this test case
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512614 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:39:48 +00:00
Benedikt Ritter 9631efe688 Methods are no longer used in test code. Make them private.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512610 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:32:19 +00:00
Benedikt Ritter 15b4e3f539 Sort members alphabetically
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512606 13f79535-47bb-0310-9956-ffa450edef68
2013-08-10 10:30:48 +00:00
Benedikt Ritter 1756e67623 Simplify if statements
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512399 13f79535-47bb-0310-9956-ffa450edef68
2013-08-09 17:09:37 +00:00
Benedikt Ritter a223126567 No need to declare private method final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1512398 13f79535-47bb-0310-9956-ffa450edef68
2013-08-09 17:06:48 +00:00
Gary D. Gregory 152d50c4f7 Remove type names from static factory APIs in org.apache.commons.csv.CSVParser.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511883 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 17:11:03 +00:00
Gary D. Gregory a36bbffdd3 Remove org.apache.commons.csv.CSVParser.parseString(String).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511868 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 16:52:00 +00:00
Gary D. Gregory 65f6f1dfe8 Package private classes are not prefixed with "CSV": CSVLexer -> Lexer.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511462 13f79535-47bb-0310-9956-ffa450edef68
2013-08-07 20:00:26 +00:00
Benedikt Ritter 643b628af4 Replace tabs with spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511428 13f79535-47bb-0310-9956-ffa450edef68
2013-08-07 18:25:44 +00:00
Gary D. Gregory 53f83b4f18 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511039 13f79535-47bb-0310-9956-ffa450edef68
2013-08-06 17:12:26 +00:00
Sebastian Bazley aede94a857 Make fields private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511015 13f79535-47bb-0310-9956-ffa450edef68
2013-08-06 16:01:24 +00:00
Sebastian Bazley 7b168ebbbe Merge Lexer with CSVLexer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511006 13f79535-47bb-0310-9956-ffa450edef68
2013-08-06 15:44:41 +00:00
Sebastian Bazley 7755640784 No longer wanted
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1511005 13f79535-47bb-0310-9956-ffa450edef68
2013-08-06 15:43:10 +00:00
Gary D. Gregory 8d8bbf459e [CSV-42] Lots of possible changes. Add Bob Smith as a contributor.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1510967 13f79535-47bb-0310-9956-ffa450edef68
2013-08-06 14:18:40 +00:00
Gary D. Gregory a064b97305 [CSV-42] Lots of possible changes: Make classes final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1510761 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 21:45:01 +00:00
Gary D. Gregory 258387e3ce Use US English spelling of 'recognized'.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1510664 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 19:10:04 +00:00
Gary D. Gregory ed72da2552 Remove extra semicolon.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1510660 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 19:03:09 +00:00
Gary D. Gregory b042bd8522 Remove primitive APIs in CSVRecord.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1510455 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 12:43:23 +00:00
Sebastian Bazley 6208f0c9af Fix up TODOs
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509967 13f79535-47bb-0310-9956-ffa450edef68
2013-08-03 11:59:28 +00:00
Sebastian Bazley 3fd92ec4a4 Use NotEscaped where character has not been escaped
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509966 13f79535-47bb-0310-9956-ffa450edef68
2013-08-03 11:51:21 +00:00
Benedikt Ritter 575c88d8a2 Add some more tests that document escaping behavior
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509957 13f79535-47bb-0310-9956-ffa450edef68
2013-08-03 11:12:48 +00:00
Benedikt Ritter 3178725e98 Align test names to other tests of the same kind
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509956 13f79535-47bb-0310-9956-ffa450edef68
2013-08-03 11:01:36 +00:00
Gary D. Gregory 70485e44f2 Add CSVRecord#getInt(String) API and tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509450 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 21:57:46 +00:00
Gary D. Gregory 4bb75e3edb Add CSVRecord#getLong(String) API and tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509449 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 21:54:37 +00:00
Gary D. Gregory ac03c2eaa7 Simplify tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509446 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 21:51:10 +00:00
Gary D. Gregory 666350b94a Sort members.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509442 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 21:48:39 +00:00
Gary D. Gregory 50b7f79338 CSVRecord.get(String) throws IAE if the column is not mapped (does not exist). This is similar to what JDBC does in ResultSet. Add getBoolean(String) API and tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509431 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 21:11:10 +00:00
Benedikt Ritter 412d05d166 Better throw a NoSuchElementException if no more elements are available because parser has been closed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509395 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 19:41:10 +00:00
Gary D. Gregory 7e63096d47 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509368 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 18:24:37 +00:00
Gary D. Gregory 7aca6adc4c [LEGAL-175] Distribute sample files from www.ferc.gov for unit tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509328 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 16:58:31 +00:00
Sebastian Bazley 86d488407b Ensure Closeable is closed
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509264 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 14:42:35 +00:00
Sebastian Bazley efdcb376e8 Don't split ternary expression over two lines
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509261 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 14:39:29 +00:00
Sebastian Bazley 4b57058ebb Remove doc for non-existent parameter
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509260 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 14:38:17 +00:00
Sebastian Bazley 105f907767 CSV-78 Use Character instead of char for char fields except delimiter
Already done as part of CSV-99 etc.
Updated Javadoc to clarify that null can be used to disable settings

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509239 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 14:02:20 +00:00
Sebastian Bazley cf764bc9ae Doc tweak
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509232 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 13:45:35 +00:00
Gary D. Gregory 1d767ad946 Sort members.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509231 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 13:43:17 +00:00
Gary D. Gregory f69ddb394a [CSV-99] Revert Builder implementation in CSVFormat. Update Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509216 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 13:05:25 +00:00
Gary D. Gregory fcc0d15c7b - Remove trailing spaces.
- Add missing final keywords.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509069 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 02:04:27 +00:00
Gary D. Gregory 316a51f520 - Add some real world CSV files.
- Add a record API to get column values using an Enum.
- Throw a better exception when a resource is not found in a class loader for the parser.
- Replace some tabs with spaces.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509068 13f79535-47bb-0310-9956-ffa450edef68
2013-08-01 02:03:33 +00:00
Gary D. Gregory 816c652997 Better example.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1509012 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 20:03:02 +00:00
Benedikt Ritter c0d91d205d Remove copy method. It is not needed since every withXxx() method returns a copy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508966 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 17:43:14 +00:00
Gary D. Gregory 55eff9dcfa Use ch instead of c as a character var name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508943 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:53:05 +00:00
Gary D. Gregory 7909a7c386 Fix boxing and unboxing warnings.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508940 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:51:20 +00:00
Gary D. Gregory 2b14b16d4b Fix NPE when format is null.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508938 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:48:54 +00:00
Gary D. Gregory a062477946 Use ch instead of c as a character var name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508937 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:46:05 +00:00
Gary D. Gregory 9599bfe743 Document empty block. Formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508936 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:43:33 +00:00
Gary D. Gregory e33dced746 Document empty block.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1508935 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 15:42:36 +00:00