Commit Graph

2114 Commits

Author SHA1 Message Date
Sebastian Bazley aeef773ed6 Calculate the booleans once; prepares for CSV-78
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305700 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 01:07:30 +00:00
Sebastian Bazley 8a683f009d CSV-75 ExtendedBufferReader does not handle EOL consistently
Fix tests

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305695 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:54:36 +00:00
Sebastian Bazley de1838ea06 CSV-75 ExtendedBufferReader does not handle EOL consistently
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305694 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:49:17 +00:00
Sebastian Bazley 0833f45bff CSV-87 CSVParser.getRecords() returns null rather than empty List at EOF
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305692 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:42:22 +00:00
Emmanuel Bourg c4e120bbf4 Added tests for line counting by the parser (CSV-75)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305689 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 00:20:21 +00:00
Emmanuel Bourg c6212540df Use JUnit 4 assertions for arrays
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305674 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:37:47 +00:00
Sebastian Bazley 8e9fb0e989 Add more info to toString() method; use space separator for clarity
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305669 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:32:18 +00:00
Emmanuel Bourg 50a89da39f Test empty files
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305668 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 23:25:48 +00:00
Emmanuel Bourg c53d3f3025 Resistance is futile
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305629 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 22:09:53 +00:00
Emmanuel Bourg e857ebfca1 Fixed floating semi columns
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305548 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 20:39:13 +00:00
Sebastian Bazley 38741a48c6 CSV-54 Confusing semantic of the ignore leading/trailing spaces parameters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305494 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 19:02:30 +00:00
Sebastian Bazley 5063b16c7a CSV-77 RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1305482 13f79535-47bb-0310-9956-ffa450edef68
2012-03-26 18:31:53 +00:00
Sebastian Bazley 4406fba31c Document existing behaviour
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304503 13f79535-47bb-0310-9956-ffa450edef68
2012-03-23 17:22:22 +00:00
Sebastian Bazley 37a261b385 Add basic toString method
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304462 13f79535-47bb-0310-9956-ffa450edef68
2012-03-23 16:19:23 +00:00
Sebastian Bazley 43987a7d78 Rename to avoid hiding class field
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1304097 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 22:16:01 +00:00
Sebastian Bazley dd26201ac4 CSV-81 Token.Type.isReady could perhaps be removed
Not removed, but only set on EOF if there is data to return

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303988 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 19:04:41 +00:00
Sebastian Bazley 8bba58d1ed Don't use == null; use assertNull
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303983 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 19:00:27 +00:00
Sebastian Bazley a1f7d8b166 Unused import
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303982 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:59:52 +00:00
Sebastian Bazley 9ebd0d9425 CSV-80 - CSVLexer.nextToken does not need wsBuf
remove useless wsBuf

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303955 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:23:22 +00:00
Sebastian Bazley 1299ddfe3f Oops - fix bug introduced in r1303933
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303948 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:15:20 +00:00
Sebastian Bazley fa07dea585 CSV-71 - Add convenience Methods to CSVLexer
Use convenience fields from Lexer parent class; missed one method replacement earlier

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303933 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 18:00:43 +00:00
Sebastian Bazley 523171ed41 Additional convenience fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303929 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:56:03 +00:00
Sebastian Bazley 83e4a903b1 CSV-71 - Add convenience Methods to CSVLexer
Use convenience methods from Lexer parent class

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303904 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:27:51 +00:00
Sebastian Bazley ff41f78ef5 Temporary copy of original CSVLexer for performance comparison.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303901 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 17:25:48 +00:00
Sebastian Bazley 1ae3639d2c CSV-71 - Add convenience Methods to CSVLexer
Added methods to Lexer parent class (updated CSVLexer to follow)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303882 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:37:01 +00:00
Sebastian Bazley fdfe50842f Allow class to be instantiated dynamically
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303879 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:32:44 +00:00
Sebastian Bazley 72e830c08c Allow testing of dynamically loaded CSVLexers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303878 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 16:28:47 +00:00
Sebastian Bazley 5111efd46d Add direct lexer tests
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303719 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 10:29:11 +00:00
Sebastian Bazley 1e0dd7b4b3 Reduce Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303699 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 09:25:44 +00:00
Sebastian Bazley 65ab9db952 Make it easy to provide an alternative lexer if required
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303620 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 23:46:44 +00:00
Sebastian Bazley 7592782eee Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303506 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:50 +00:00
Sebastian Bazley 3ea8118ff3 Move Token into separate file for more flexibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303505 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:04:32 +00:00
Sebastian Bazley 0519364a83 Excel works as well for the input file
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303504 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 19:03:30 +00:00
Sebastian Bazley 75bd702468 CSV-74 - CSVFormat definitions are difficult to read and maintain
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303488 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:20:05 +00:00
Sebastian Bazley 9fb2b4f2b1 CSV-79 - CSVFormat.isCommentingDisabled() is confusing/confused
renamed method to isCommentingEnabled and fixed code

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303483 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 18:13:54 +00:00
Sebastian Bazley d0035e6c7a headerMapping is only created once, so make it final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1303455 13f79535-47bb-0310-9956-ffa450edef68
2012-03-21 16:01:31 +00:00
Sebastian Bazley 10bf28ee2e eol native
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302383 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 11:52:10 +00:00
Sebastian Bazley 101a040805 Provide initial description
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302263 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 03:08:09 +00:00
Sebastian Bazley 4c5dbfefa5 We need a description
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302262 13f79535-47bb-0310-9956-ffa450edef68
2012-03-19 03:03:42 +00:00
Sebastian Bazley 564e8244b6 create strings for each field
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302039 13f79535-47bb-0310-9956-ffa450edef68
2012-03-18 00:00:36 +00:00
Sebastian Bazley b227c29978 Add tests of ExtendedBufferedReader for comparison
Allow tests to be configured dynamically


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1302037 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 23:34:42 +00:00
Sebastian Bazley 462af64456 Simplify
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301973 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:19:22 +00:00
Sebastian Bazley 83b1072703 Add test for CSV-75
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301971 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 18:17:15 +00:00
Sebastian Bazley a019caec3f Simplify assertions, and provide details if the strings are not equal
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301967 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 17:36:38 +00:00
Sebastian Bazley 16278171d2 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301938 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 13:37:54 +00:00
Sebastian Bazley c9dedff12e CSV-67 UnicodeUnescapeReader should not be applied before parsing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301928 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 12:29:15 +00:00
Henri Yandell 29efef70f1 Updating copyright dates in notice per expressive last entries in each components svn log
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301865 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 05:09:23 +00:00
Sebastian Bazley 9a705d8605 Initial checkin of test harness
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301864 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:57:49 +00:00
Sebastian Bazley d422c1a8b5 Simplify and avoid boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301862 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:17:44 +00:00
Sebastian Bazley 530c93392c @Override; explicit unboxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1301861 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 04:12:16 +00:00