Commit Graph

222 Commits

Author SHA1 Message Date
Gary Gregory 66243ac2a9 Update tests from commons-io:commons-io 2.6 to 2.7. 2020-05-28 08:11:29 -04:00
Gary Gregory 914f2c4155 Move resources to component specific folder. 2020-05-28 08:10:18 -04:00
Gary Gregory 56b626f0d9 Move site files to their propper locations (not in the production
folder.)
2020-04-10 17:28:08 -04:00
Gary Gregory ae936c0e73 Move site files to their propper locations (not in the production
folder.)
2020-04-10 17:26:10 -04:00
Gary Gregory 2906565c56 Reset to RC1. 2020-04-10 15:23:16 -04:00
Gary Gregory cab61c53f1 Update tests from Apache Commons Lang 3.9 to 3.10. 2020-03-27 14:09:05 -04:00
Chen 5591444148
Fix the old test case record.getComment() will never be null (#62)
* The old test case record.getComment() will never be null and if record.getComment() be null the test code misplace the null test.
Add a new test file that record.getComment() will be null and test record.getComment() no null before using

* keep the caching of "record.getComment()"
2020-03-24 21:04:14 -04:00
Gary Gregory 72edc56862 org.junit.jupiter:junit-jupiter from 5.6.0 to 5.6.1. 2020-03-23 11:12:35 -04:00
Gary Gregory c2f46df203 [CSV-184] Make the method CSVRecord#putIn(Map) public. 2020-03-23 09:39:19 -04:00
Gary Gregory ea7ffd7b8e Rename pmd.version to commons.pmd.version to match commons-parent. 2020-03-17 11:14:14 -04:00
Gary Gregory c255268aa1 maven-pmd-plugin 3.12.0 -> 3.13.0. 2020-03-17 11:06:17 -04:00
Gary Gregory 2dd3606127 org.mockito:mockito-core 3.2.4 -> 3.3.3. 2020-03-17 10:56:03 -04:00
Chen 953a6de722
fix isssue csv-259 (#61)
* fix isssue csv-259

* add testcase for CSV259

* exclude csv259 test file

* organize the imports
2020-03-17 10:51:01 -04:00
Amey Jadiye d83dab4b09
replace findbugs with spotbugs (#56) 2020-02-12 16:14:28 -05:00
Gary Gregory 0ab1318a44 Bump to next development version 2020-02-06 16:01:56 -05:00
Gary Gregory 660f7c9f85 Merge branch 'master' into release 2020-02-01 20:04:04 -05:00
Gary Gregory df9da1056b Prepare for 1.8-RC2.
- Remove package private code with Java 8 equivalent
java.util.Objects.requirteNonNull().
- Checkstyle fixes.
- Use final.
- Remove unused import.
2020-02-01 20:01:01 -05:00
Gary Gregory b7fea5546b [CSV-248] CSVRecord is not Serializable.
Exclude binary test fixtures from Apache RAT consideration.
2020-01-22 10:28:05 -05:00
Gary Gregory 07101a99bc [CSV-248] CSVRecord is not Serializable.
Update JUnit from 5.5.2 to 5.6.0.
2020-01-20 18:36:02 -05:00
Gary Gregory c1c8b32809 Update POM version numbers for Apache Commons CSV release 1.8 2020-01-18 11:55:06 -05:00
Gary Gregory 7d86ab0ced Prepare for the next release. 2020-01-18 11:33:16 -05:00
Chen 8ecd4657ef Fix typos in site and test #53 2019-12-30 08:43:55 -05:00
Gary Gregory abc65e41a6 Update tests from Mockito 3.2.0 to 3.2.4. 2019-12-20 22:54:11 -05:00
Gary Gregory 7cc7b596ca Update tests from Mockito 3.1.0 to 3.2.0. 2019-12-12 11:04:02 -05:00
Gary Gregory b0c544e911 Update tests from Hamcrest 2.1 to 2.2. 2019-12-12 11:02:35 -05:00
Gary Gregory 33bb4f0e01 Update tests from H2 1.4.199 to 1.4.200. 2019-12-12 10:59:50 -05:00
Allon Murienik e2f0a4d8a8 CSV-252: Migration to JUnit Jupiter (#49)
* CSV-252 Stop using junit.framework.TestCase

junit.framework.TestCase is a class from JUnit 3, and while it is not
officially deprecated, it's discouraged to use it.

This patch removes the single use of
junit.framework.TestCase#assertNull, and replaces it with the
standard, recommended, org.junit.Assert#assertNull.

* CSV-252 Standardize org.junit.Assert imports

Code in the project uses org.junit.Assert's methods in two ways:
1. By statically importing them
2. By importing the class and using its methods

Option 1 seems to be the de-facto standard, with just a handful of
cases using Option 2.
This patch standardizes these cases to also use static imports thus
making the code look more uniform, and easier to maintain.

* CSV-252 Upgrade Mockito to 3.1.0

Upgrade the Mockito dependency to the latest available version, 3.1.0,
in order to facilitate an upgrade to JUnit Jupiter.

* CSV-252 JUnit Jupiter upgrade

This patch upgrades the project's testing framework from JUnit 4.12
to the modern JUnit Jupiter 5.5.4.

Since JUnit 5 Jupiter is not backwards compatible to JUnit 4.x (or
even JUnit Vintage), this patch is a bit large, even though a lot of
the changes are merely cosmetic (such as changing the argument order,
see details below). In order to make the reviewer's task as easy as
possible, this PR does not presume to use JUnit Jupiter's best
practices and all its new functionality, but only to migrate the
existing tests with as little change as possible. Following patches
may want to improve the tests by using some of JUnit Jupiter's new
features.

This patch includes the following changes:

1. Maven dependency changes:
 a. junit:junit was replaced with org.junit.jupiter:junit-jupiter.
 b. org.hamcrest:hamcrest was introduced as an explicit dependency,
    since the project uses Hamcrest, and JUnit Jupiter does not
    bundle Hamcrest, unlike JUnit 4.x.

2. Annotations:
 a. org.junit.jupiter.api.Test was used as a drop in replacement for
    org.juit.Test without arguments. See 3.ii. for handling of @Test
    annotations with an "expected" argument.
 b. org.junit.jupiter.api.BeforeEach was used as an drop in
    replacement for org.junit.Before.
 c. org.junit.jupiter.api.BeforeAll was used as an drop in
    replacement for org.junit.BeforeClass.
 d. org.junit.jupiter.api.Disabled was used as a drop in replacement
    for org.junit.Ignore.

3. Assertions:
 a. org.junit.jupiter.api.Assertions' methods were used as drop in
    replacements for org.junit.Assert's methods with the same name in
    the simple case of an assertion without a message. In the case of
    an assertion with a message, org.junit.jupiter.api.Assertions'
    methods were used, but the argument order was changed - Assert's
    methods take the message as the first argument, while Assertions'
    methods take the message as the last argument.
 b. org.junit.jupiter.api.Assertions#assertThrows was used to assert
    that a specific exception was throws instead of an org.junit.Test
    annotation with an expected argument. This technique has a couple
    of side bonuses. First, it makes the tests slightly stricter, as
    now they can assert the exception was thrown from a specific line
    and prevent false positives where the test's "set-up" code
    accidentally threw that exception. Second, it clarifies that some
    of the test code is unreachable (as a previous line already
    throws an exception), and can safely be removed in order to clean
    up the test. The throws clauses of these methods were cleaned up
    from exceptions that can no longer be thrown in order to avoid
    compilation warnings.
 c. org.hamcrest.MatcherAssert#assertThat was used as a drop in
    replacement for org.junit.Assert#assertThat.

4. Specific Changes:
 a. CSVFileParserTest was rewritten with JUnit Jupiter's
    org.junit.jupiter.api.ParameterizedTest. Unlike JUnit 4's
    org.junit.runners.Parameterized, it cannot be used to inject
    arguments to a test's construct, and so the test can't be
    stateful. Instead, it was rewritten so every test receives the
    file as a parameter, and opens a reader on it itself. As a side
    bonus, this design makes it easier to close the reader and avoid
    leaving open file descriptors like the original test did.
2019-10-05 14:59:58 -04:00
Gary Gregory 2f1ac70815 Update properties for the next release. 2019-09-09 20:41:53 -04:00
Gary Gregory 09f4bed945 Revert change to commons.componentid. 2019-09-09 20:41:07 -04:00
Gary Gregory d4ceb0a125 Point to the Java 8 Javadocs. 2019-09-09 15:26:04 -04:00
Gary Gregory 1141e9b2be Set component ID to commons-csv. 2019-09-09 15:20:36 -04:00
Sebb d9745feba3 git-wip-us => gitbox 2019-08-16 18:34:19 +01:00
sullis 363dd18906 use [test] scope for supercsv (#48) 2019-08-14 11:38:10 -07:00
Gary Gregory d06d048063 Use HTTPS to access Apache resources. 2019-07-06 20:41:48 -04:00
Gary Gregory 7e669566df Use HTTPS links to Apache. 2019-07-04 10:00:21 -04:00
Alex Herbert 03550ab565 Post release fixes (#44)
* Fix checkstyle: remove tabs
* Fix checkstyle: Split long line
* Fix checkstyle: exclude pom.properties
* Update findbugs to allow deliberate fall-through
* Fix pmd: Remove ternary operator returning false
* Fix pmd: Remove implicit final
* Fix pmd: Ignore TooManyStaticImports.

This requires adding the default ruleset and then modifying with
suppressions.

* Add tests to cover use of the IOUtils class.

Requires the CSVFormat to have no quote or escape character, and the
formatted value to be a java.io.Reader.

* Clean-up findbugs exclude filter.
* Removed unused import
* Updated test comments for print tests targeting IOUtils.
* Fix checkstyle: Suppress line length warning in CSVParser.
2019-06-15 13:52:44 -04:00
Gary Gregory 7d100bf05b Bump to next development version 2019-06-05 08:29:56 -04:00
Gary Gregory a227a1e2fb Update POM version numbers for Apache Commons CSV release 1.7 2019-06-01 20:09:24 -04:00
Gary Gregory 33bfaeef8a Prepare for release 1.7.
- There is no longer site archives. We forgot to do it for 1.6 but the
sites are still in svn.
- The Javadoc archives now point to the same place GitHub uses:
javadoc.io
- Checkstyle fixes.
2019-06-01 17:20:20 -04:00
Gary Gregory d346048552 Fix warning reported by 'mvn versions:display-plugin-updates' 2019-05-20 08:27:36 -04:00
Gary Gregory 5722332c9a Fix warning reported by 'mvn versions:display-plugin-updates' 2019-05-20 08:25:08 -04:00
Gary Gregory 3fa020303b javancss-maven-plugin blows up, drop it. 2019-05-20 08:21:43 -04:00
Gary Gregory 734e7a910f Update maven-pmd-plugin from 3.11.0 to 3.12.0. 2019-04-23 16:02:26 -04:00
Gary Gregory 01e7e384ac Update tests from Apache Commmons Lang 3.8.1 to 3.9. 2019-04-14 20:26:30 -04:00
Gary Gregory 7c1a3fab64 Update Apache Commons Parent from 47 to 48. 2019-03-25 12:00:31 -04:00
Gary Gregory 4e438b9f81 Update tests from H2 1.4.198 to 1.4.199. 2019-03-13 12:08:41 -04:00
Gary Gregory 1305ef1029 [CSV-237] Update to Java 8. 2019-02-24 10:04:45 -05:00
Gary Gregory f69a78972f Inherit plugin version from commons-parent. 2019-02-23 09:39:33 -05:00
Gary Gregory 293fa4dec3 Update Maven PMD Plugin from 3.8 to 3.11.0. 2019-02-23 09:38:00 -05:00
Gary Gregory 17be5351cb Update Maven Checktyle Plugin from 2.7 to 3.0.0. 2019-02-23 09:33:17 -05:00