Commit Graph

1806 Commits

Author SHA1 Message Date
Gary D. Gregory df592767fc Fix param name and Javadoc to match ivar names.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397925 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:58:56 +00:00
Gary D. Gregory c7576ccded Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397924 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:57:09 +00:00
Gary D. Gregory 2a8ce4a11c Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397923 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 18:56:57 +00:00
Gary D. Gregory 0f8cc2228c In-line comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397915 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:45:31 +00:00
Gary D. Gregory 8c3aaee61a Rename method from "is" prefix to "read" prefix because it is not just a test method, it may actually consume input.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397914 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:45:05 +00:00
Gary D. Gregory d37f1a6ed7 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397913 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:42:06 +00:00
Gary D. Gregory 9f6d3f5413 Rename readAgain() to getLastChar()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397911 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:40:05 +00:00
Gary D. Gregory f342cb2caf Validation checks the delimiter character cannot be null.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397909 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:38:39 +00:00
Gary D. Gregory 0e7e9deabb Make package private classes final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397907 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:28:56 +00:00
Gary D. Gregory 17c26354df org.apache.commons.csv.Token.reset() does not need to return itself. Save a return.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397906 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:24:27 +00:00
Gary D. Gregory aa4d069a7f Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397904 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:20:04 +00:00
Gary D. Gregory 6306dd7181 In-line comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397903 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:18:56 +00:00
Gary D. Gregory 9542a399b8 It looks like TWO record objects were created for each record read!
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397902 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:16:41 +00:00
Gary D. Gregory 0e8084ab27 Rename getRecord() to nextRecord()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397900 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:13:18 +00:00
Gary D. Gregory 3b938ba40d Let the line number count be a long.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397898 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:11:42 +00:00
Gary D. Gregory daf984983b [CSV-52] Keep track of record numbers.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397895 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 17:09:48 +00:00
Gary D. Gregory 3d72cb087a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397889 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:23:02 +00:00
Sebastian Bazley 03a6b50319 Add missing single-quote
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397878 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:11:54 +00:00
Gary D. Gregory 933a950c88 [CSV-88] Not possible to create a CSVFormat from scratch. Should the validate method be public?
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397877 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:10:33 +00:00
Gary D. Gregory ae47fb8432 CSVFormat.validate() throws IllegalStateException instead of IllegalArgumentException because the method validates the state of the object.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397876 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:08:44 +00:00
Gary D. Gregory e331df694c Use the single quote char to delineate a char in error messages. Remove a trailing space.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397872 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 16:03:03 +00:00
Gary D. Gregory 8f068b60ed Rename method nullMeansDisabled() to mapNullToDisabled()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397864 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:43:40 +00:00
Gary D. Gregory ef9018bb1e [CSV-94] Lexer should only use char fields.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397863 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:41:56 +00:00
Sebastian Bazley 96a55f1d2b Drop @Ignore from perf/PerformanceTest; instead add to pom surefire excludes
This makes it possible to run the test without needing to edit the source file.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397859 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:30:07 +00:00
Sebastian Bazley d99244287c Use locally stored big file as per perf/PerformanceTest
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397851 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 15:15:36 +00:00
Gary D. Gregory 992c0645e0 Rename ivar to ignoreEmptyLines to match CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397785 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:29:09 +00:00
Gary D. Gregory 3655efcedb Rename ivar to ignoreSurroundingSpaces to match CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397784 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:28:47 +00:00
Gary D. Gregory 50e2719bb6 Remove DISABLED character hack.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397783 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 06:27:52 +00:00
Gary D. Gregory dc7a71979d Rename constant.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397772 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:41:12 +00:00
Gary D. Gregory bb7d696218 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397771 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:39:15 +00:00
Gary D. Gregory ba609af7e3 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397770 13f79535-47bb-0310-9956-ffa450edef68
2012-10-13 05:30:00 +00:00
Gary D. Gregory 48b26f82f7 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397579 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 14:26:35 +00:00
Gary D. Gregory 9428b9cc1a Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397574 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 14:15:25 +00:00
Gary D. Gregory 8159aea6d1 Update CRLF to be easier to read.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397562 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:48:26 +00:00
Gary D. Gregory 883a0e91cf Allow performance test to traverse column values (optional).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397559 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:31:06 +00:00
Gary D. Gregory 53fd86dfbc More constants clean ups.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397556 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:15:30 +00:00
Gary D. Gregory b5c334222c Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397549 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:58:29 +00:00
Gary D. Gregory 56ca5858db Refactor constants from various classes into a package private Constants class and use static imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397541 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:35:46 +00:00
Gary D. Gregory 9a27bb570d Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397536 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:16:38 +00:00
Gary D. Gregory 66a56ee1a4 Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397534 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:12:44 +00:00
Gary D. Gregory a5cd9dc1c5 Fix constant name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397530 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 12:00:35 +00:00
Gary D. Gregory 5b6b1fa33c Refactor magic strings into constants.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397527 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 11:58:50 +00:00
Sebastian Bazley af4a695069 IO 2.4 requires Java 1.6
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397413 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 01:36:57 +00:00
Gary D. Gregory 625bafab76 Add CVSRecord.isSet(String) API.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397136 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 16:07:51 +00:00
Gary D. Gregory 6ab9b46e5a Use final keyword where possible.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397122 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 15:47:44 +00:00
Gary D. Gregory db374369ae Better performance tests. Provide a test CSV file to work with. Tests depends on Commons IO to help decompress the large-ish CSV test file.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397119 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 15:45:13 +00:00
Gary D. Gregory 3eededce88 Add CVSRecord.isMapped(String) API.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397094 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:56:16 +00:00
Gary D. Gregory 67bbc35289 Rename ivars that were in the past tense to use the imperative style.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397087 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:39:23 +00:00
Gary D. Gregory b5589d0fcb Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397080 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:31:43 +00:00
Gary D. Gregory 3ea85d4c8b Replace magic char with constant TAB.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397078 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 14:30:04 +00:00