282 Commits

Author SHA1 Message Date
Benedikt Ritter
c4014b6b38 Method names should start with a verb
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460136 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 12:48:24 +00:00
Benedikt Ritter
9bafed6b23 Clarify JavaDoc for builder factory method, also remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1460134 13f79535-47bb-0310-9956-ffa450edef68
2013-03-23 12:01:25 +00:00
Gary D. Gregory
e28d4e9c2e Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459447 13f79535-47bb-0310-9956-ffa450edef68
2013-03-21 18:47:40 +00:00
Gary D. Gregory
6e2c992072 content ivar can be final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459444 13f79535-47bb-0310-9956-ffa450edef68
2013-03-21 18:42:03 +00:00
Benedikt Ritter
3f0faa00ed Add missing JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1459020 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 19:52:27 +00:00
Benedikt Ritter
b53a171ab3 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458805 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:43:43 +00:00
Benedikt Ritter
20fe471d40 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458803 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:42:37 +00:00
Benedikt Ritter
c99e6d9ef6 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458797 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:40:33 +00:00
Benedikt Ritter
961cce294c Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458794 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:39:18 +00:00
Benedikt Ritter
62a527636d Remove trailing white space
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458791 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 12:38:45 +00:00
Benedikt Ritter
2018c0c41f Replace accidentally checked in tab characters with spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458721 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 10:23:30 +00:00
Benedikt Ritter
5e0e7703a1 Format lines that are longer than 120 characters
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458713 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 10:08:17 +00:00
Benedikt Ritter
374cd7b16d Remove trailing white spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458683 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 08:31:14 +00:00
Gary D. Gregory
6b1eaad5a6 Javadoc fixes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458636 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:16:26 +00:00
Gary D. Gregory
0956f6e85d Use the same wording in Javadoc as in the API name: "empty".
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458635 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:09:48 +00:00
Gary D. Gregory
e2e8c2523c Fix spelling in Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458634 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:08:36 +00:00
Gary D. Gregory
f656bb7cb6 Fix spelling in Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458633 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:07:05 +00:00
Gary D. Gregory
46b6a2de4c Fix Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458632 13f79535-47bb-0310-9956-ffa450edef68
2013-03-20 05:03:17 +00:00
Gary D. Gregory
f6f02e5265 Fix formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1458139 13f79535-47bb-0310-9956-ffa450edef68
2013-03-19 04:54:38 +00:00
Gary D. Gregory
71a657004e Where possible:
- Add final modifier to private fields
- Add final modifier to method parameters
- Add final modifier to local variables

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1429926 13f79535-47bb-0310-9956-ffa450edef68
2013-01-07 18:00:46 +00:00
Sebastian Bazley
e5a7b27224 More useful to have double-quote as a Character
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411920 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:24:58 +00:00
Sebastian Bazley
713e9c5382 Make some methods package-protected to avoid the need for synthetic accessors.
TODO consider whether to do so for the fields as well

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411919 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:22:21 +00:00
Sebastian Bazley
0e35052508 Correct name of character: it's not an escape, it's a backslash
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1411918 13f79535-47bb-0310-9956-ffa450edef68
2012-11-20 23:11:09 +00:00
Gary D. Gregory
db11c04d29 [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410759 13f79535-47bb-0310-9956-ffa450edef68
2012-11-17 18:00:38 +00:00
Gary D. Gregory
8b622677c6 Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410082 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:45:24 +00:00
Gary D. Gregory
8886fac6d7 Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410081 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:44:44 +00:00
Gary D. Gregory
7fa5b4e68f Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410080 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:44:23 +00:00
Gary D. Gregory
eeeafa5faa Set Id SVN property.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410079 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 22:43:52 +00:00
Gary D. Gregory
0383fd51df [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1410045 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 21:56:36 +00:00
Gary D. Gregory
68352ee98f Use the final keyword where possible.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409464 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:58:09 +00:00
Gary D. Gregory
cdc8b8f2b1 Organize imports.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409461 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:56:46 +00:00
Gary D. Gregory
7ac5dd3ec6 Rename methods that create a builder newBuilder().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409455 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:54:16 +00:00
Gary D. Gregory
6a34b823c8 [CSV-68] Use the Builder pattern for CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1409449 13f79535-47bb-0310-9956-ffa450edef68
2012-11-14 21:50:36 +00:00
Sebastian Bazley
d266471b4c Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399051 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:09:05 +00:00
Gary D. Gregory
7e67e14bb3 A field was left public.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399049 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:06:14 +00:00
Sebastian Bazley
3daeb02c08 Since DEFAULT is supposed to be RFC4180 + ignore blank lines: make it so
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399048 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:06:10 +00:00
Gary D. Gregory
e04a86ae11 Remove whitespace.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399047 13f79535-47bb-0310-9956-ffa450edef68
2012-10-17 00:05:42 +00:00
Gary D. Gregory
5a7138a1da Javadoc fix.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1399045 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 23:44:35 +00:00
Gary D. Gregory
73ec29f75f Rename "line separator" to "record separator".
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398911 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 18:20:52 +00:00
Gary D. Gregory
933cf2d038 Add // TODO comment.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398749 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 11:51:22 +00:00
Gary D. Gregory
ef8a489172 Javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398748 13f79535-47bb-0310-9956-ffa450edef68
2012-10-16 11:50:29 +00:00
Sebastian Bazley
42757c2376 Multi-parameter ctor is confusing and unnecessary
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398563 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 23:02:59 +00:00
Sebastian Bazley
060fd48fe4 Oops, forgot to use DISABLED char
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398561 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 23:00:43 +00:00
Sebastian Bazley
5c9b878dfd PRISTINE can now be private as we have ctor which allows delimiter to be specified
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398560 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:57:51 +00:00
Sebastian Bazley
6f500d6067 Re-introduce DISABLED but as a private constant; only needed for PRISTINE definition
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398559 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:56:54 +00:00
Sebastian Bazley
cbce4da24b Add ctor to create simplest possible CSV parser
Does not make sense to allow delim = EOL in ctor but disable it in withDelimiter()

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398556 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 22:50:00 +00:00
Sebastian Bazley
91058bb95f Typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398370 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:29:37 +00:00
Sebastian Bazley
7d8c7f17ff Remove redundant code
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398367 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:27:57 +00:00
Sebastian Bazley
3a90cfe249 Explicit unboxing; associated Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398365 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:27:25 +00:00
Sebastian Bazley
33c004f525 Invalid use of == to compare Character equality; add tests to detect this
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1398357 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 16:04:29 +00:00