Commit Graph

2048 Commits

Author SHA1 Message Date
Gary Gregory 5a7b030537
Merge pull request #279 from aherbert/csvparser-duplicate-missing-headers
CSVParser: Identify duplicates in null, empty and blank header names (WIP)
2022-10-25 21:23:51 -04:00
aherbert 69aa686187 CSV-264: CSVParser identifies null, empty or blank headers as 'missing'
Duplicate missing header names are handled consistently between
CSVFormat and CSVParser.

Document that the ignore header case flag is for parser behaviour.

Update CSVDuplicateHeaderTest to add the ignore header case flag to
tests. Add test cases with case insensitive duplicates.
2022-10-25 22:25:16 +01:00
Gary Gregory 8ad07df0d4 Use try-with-resources 2022-10-23 16:59:56 -04:00
Gary Gregory 5d494a6fd6 Match comment to pinned commit 2022-10-23 15:13:03 -04:00
Gary Gregory cafb4d2f43 Update for Scorecards 2 2022-10-23 15:11:16 -04:00
Gary Gregory 540c778ad3 Update for Scorecards 2 2022-10-23 15:05:14 -04:00
Gary Gregory 07608e864e Update for Scorecards 2 2022-10-23 15:03:08 -04:00
Alex Herbert bd48a767cd CSVFormat: Sanitise empty headers to the empty string ""
Add more tests for duplicate headers including null header names.
2022-10-23 19:37:32 +01:00
Gary Gregory 481d8b1ff3
Update comment to match PR bump to 2.0.6 2022-10-23 14:12:45 -04:00
Gary Gregory 1b4e3af81a
Merge pull request #277 from apache/dependabot/github_actions/ossf/scorecard-action-2.0.6
Bump ossf/scorecard-action from 1.1.2 to 2.0.6
2022-10-23 13:53:53 -04:00
Gary Gregory de47291978 Test for empty/blank headers the same way for input and output 2022-10-23 09:09:26 -04:00
Gary Gregory b6c63e47d9 Update test case for cases that are only supported for parsing 2022-10-22 15:04:12 -04:00
Alex Herbert 4ddeddc2a1 Test javadoc updates and typos 2022-10-22 18:45:45 +01:00
Alex Herbert 1c0a8f12e6 Fix typo 2022-10-22 18:39:16 +01:00
Alex Herbert 24ffa7b4cf Add test for duplicate header names
Test the CSVFormat and CSVParser handle the headers consistently.

CSVParser handles all 36 cases.

CSFFormat fails 6 cases. These are currently disabled.
2022-10-22 18:23:31 +01:00
Gary Gregory 8d57c918ff Bump mockito-core from 4.8.0 to 4.8.1 2022-10-22 08:54:13 -04:00
Gary Gregory 3992019933 Javadoc and format tweaks 2022-10-22 08:52:41 -04:00
Gary Gregory 289ffa1627 Validates that a CSVFormat rejects empty header names 2022-10-22 08:38:52 -04:00
Gary Gregory 8fbf1b1acf Explicitly test a method JaCoCo says is not tested but should be 2022-10-22 07:50:16 -04:00
Alex Herbert 375cefcfe0 Add missing @Test annotations 2022-10-21 16:51:54 +01:00
Gary Gregory 2fff399d1a Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-csv.git 2022-10-21 08:59:22 -04:00
Gary Gregory b4799e799a Add testGetDuplicateHeaderMode() 2022-10-21 08:59:14 -04:00
Gary Gregory db16af9106 Sort member 2022-10-21 08:55:26 -04:00
dependabot[bot] 0829b0d7a1 Bump actions/setup-java from 3.5.1 to 3.6.0
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v3.5.1...v3.6.0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-22 01:18:54 +13:00
Gary Gregory d19e44c88f Fill in the test coverage for getAllowDuplicateHeaderNames() to reflect
the _current_ behavior, right or wrong.
2022-10-21 08:17:15 -04:00
Gary Gregory 4e4f27029c Inline single use variable 2022-10-21 08:06:25 -04:00
dependabot[bot] 8d72b51dd6
Bump ossf/scorecard-action from 1.1.2 to 2.0.6
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.6.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ce330fde6b...99c53751e0)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-21 12:01:20 +00:00
Gary Gregory da8bad9df0 Bump CSVFormat#serialVersionUID from 1 to 2
Javadoc Serialization in CSVFormat is not supported from one version to
the next.
2022-10-21 07:53:48 -04:00
Gary Gregory 37946b27c2 Reset POM version after merge from the release branch 2022-10-20 10:19:21 -04:00
Gary Gregory 669a2ca2b0 Add/fix missing Javadoc since tag 2022-10-16 13:44:28 -04:00
Gary Gregory 2d11aab733 Fix since tag 2022-10-16 13:42:00 -04:00
Gary Gregory 72ba42e3e7 Add missing code coverage 2022-10-16 13:41:47 -04:00
Gary Gregory 9134e957c0 Fix formatting 2022-10-16 13:35:34 -04:00
Gary Gregory fc2848b025 Enable some CSVPrinterTest tests
* testJira135_part1
* testJira135_part3
* testRandomPostgreSqlText
2022-10-16 13:27:10 -04:00
Gary Gregory 5433169b79 Enable JiraCsv213Test 2022-10-16 13:21:20 -04:00
Gary Gregory 7165be4dcc Add CI management section 2022-10-16 13:04:34 -04:00
Gary Gregory 7d862e6d6c Remove deprecated PMD rules. 2022-10-16 12:56:02 -04:00
Gary Gregory 6aa3665d93 Only link to dependency-info.html instead of hard-coding a single method 2022-10-16 12:51:40 -04:00
Gary Gregory 1bd1fd8e60 Update POM version for Apache release 1.10.0 2022-10-16 08:26:37 -04:00
Gary Gregory dc786a4cf5 Prepare release candidate 2022-10-16 08:16:22 -04:00
Gary Gregory 6fce181abf Refactor duplicate code
Normalize Javadoc first word
2022-10-16 08:03:47 -04:00
Gary Gregory 0047fb0a65 Refactor code duplication in tests 2022-10-15 10:31:17 -04:00
Gary Gregory 6293899720 Simplify test 2022-10-15 10:22:34 -04:00
Gary Gregory 989116cdb1 Use final
Remove unused imports
2022-10-15 10:16:32 -04:00
Gary Gregory 93af662ddd Enable doclint for GitHub builds 2022-10-15 10:12:52 -04:00
Gary Gregory 22df0e28c4 Fix Javadoc links 2022-10-15 10:12:39 -04:00
Gary Gregory 3d5f711d33 Pickup maven-pmd-plugin dependency in parent POM 2022-10-15 09:55:33 -04:00
Gary Gregory 8b3ea51081 Pickup maven-checkstyle-plugin dependency in parent POM 2022-10-15 09:54:36 -04:00
Gary Gregory 57ab1981ea Normalize first word of Javadocs
- "getFoo" methods "Gets foo"
- "isFoo" methods "Tests foo"
2022-10-15 09:42:41 -04:00
Gary Gregory c04fc6c022 Javadoc: Add missing since tag 2022-10-15 09:41:01 -04:00