Commit Graph

2048 Commits

Author SHA1 Message Date
belugabehr 3ac702b190
CSV-278: Reuse Buffers in Lexer for Delimiter Detection (#162)
* CSV-278: Reuse Buffers in Lexer for Delimiter Detection

* Remove erroneous tab character

* Reduce change set with fewer formatting changes

* Reduce change set with fewer formatting changes
2021-07-15 09:41:22 -04:00
Gary Gregory a4e005fdf5 No need for separate Maven invocation to display version. Drop empty
lines.
2021-07-15 09:27:29 -04:00
Gary Gregory e74bd37a6d Formalize PerformanceTest #168. 2021-07-15 09:05:17 -04:00
belugabehr 47479b6305
CSV-284: Formalize PerformanceTest (#168)
* CSV-284: Formalize PerformanceTest

* Revert some changes
2021-07-15 09:03:51 -04:00
Gary Gregory a2ba9b5288 Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0.
Fix SpotBugs Errors
- Error: Medium: org.apache.commons.csv.CSVParser.getHeaderNames() may
expose internal representation by returning CSVParser.headerNames
[org.apache.commons.csv.CSVParser] At CSVParser.java:[line 599]
EI_EXPOSE_REP
- Error: Medium: new org.apache.commons.csv.CSVParser(Reader, CSVFormat,
long, long) may expose internal representation by storing an externally
mutable object into CSVParser.format [org.apache.commons.csv.CSVParser]
At CSVParser.java:[line 433] EI_EXPOSE_REP2
- Error: Medium: new org.apache.commons.csv.CSVParser(Reader, CSVFormat,
long, long) may expose internal representation by storing an externally
mutable object into CSVParser.headerMap
[org.apache.commons.csv.CSVParser] At CSVParser.java:[line 437]
EI_EXPOSE_REP2
- Error: Medium: new org.apache.commons.csv.CSVParser(Reader, CSVFormat,
long, long) may expose internal representation by storing an externally
mutable object into CSVParser.headerNames
[org.apache.commons.csv.CSVParser] At CSVParser.java:[line 438]
EI_EXPOSE_REP2
- Error: Medium: new org.apache.commons.csv.CSVPrinter(Appendable,
CSVFormat) may expose internal representation by storing an externally
mutable object into CSVPrinter.format
[org.apache.commons.csv.CSVPrinter] At CSVPrinter.java:[line 100]
EI_EXPOSE_REP2

Suppresss SpotBugs Errors:
- Error: Medium: org.apache.commons.csv.CSVFormat$Predefined.getFormat()
may expose internal representation by returning
CSVFormat$Predefined.format [org.apache.commons.csv.CSVFormat$Predefined]
At CSVFormat.java:[line 758] EI_EXPOSE_REP
- Error: Medium: org.apache.commons.csv.CSVParser.iterator() may expose
internal representation by returning CSVParser.csvRecordIterator
[org.apache.commons.csv.CSVParser] At CSVParser.java:[line 690]
EI_EXPOSE_REP
- Error: Medium: org.apache.commons.csv.CSVRecord.getParser() may expose
internal representation by returning CSVRecord.parser
[org.apache.commons.csv.CSVRecord] At CSVRecord.java:[line 171]
EI_EXPOSE_REP
2021-07-14 11:29:27 -04:00
Gary Gregory bda783580a [CSV-279] Optimize Lexer Delimiter Check for One Character Delimiter
#163.
2021-07-13 20:25:19 -04:00
belugabehr f7c067d9b2
CSV-279: Optimize Lexer Delimiter Check for One Character Delimiter (#163) 2021-07-13 20:24:06 -04:00
Gary Gregory cdbc8925d9 [CSV-282] Document and Automate CSV Benchmark Harness #166. 2021-07-13 20:21:48 -04:00
belugabehr 0771927c8f
CSV-282: Document and Automate CSV Benchmark Harness (#166)
* CSV-282: Document and Automate CSV Benchmark Harness

* Editorial improvements
2021-07-13 20:21:10 -04:00
Gary Gregory c640d162ba [CSV-283] Remove Whitespace Check Determines Delimiter Twice #167. 2021-07-13 20:18:04 -04:00
belugabehr d617b6720a
CSV-283: Remove Whitespace Check Determines Delimiter Twice (#167) 2021-07-13 20:16:59 -04:00
Gary Gregory dced5f77fe Update tests from commons-io:commons-io 2.10.0 to 2.11.0. 2021-07-13 17:47:20 -04:00
Gary Gregory 3627c5ae83 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-csv 2021-07-13 10:50:23 -04:00
Gary Gregory 8f80d2ca25 [CSV-281] Update CSVBenchmark #165. 2021-07-13 10:50:12 -04:00
belugabehr 10a9051682
CSV-281: Update CSVBenchmark (#165)
* CSV-281: Update CSVBenchmark

* Restore split Benchmark to use BufferedReader
2021-07-13 10:47:59 -04:00
Gary Gregory 3b959626f4 Better internal names. 2021-07-11 13:54:43 -04:00
Gary Gregory 8a5a0656d7 Use final. 2021-07-10 09:44:52 -04:00
Gary Gregory 66da39dd6f Better resource management. 2021-07-09 11:26:50 -04:00
Gary Gregory d1602acd6c Better resource management. 2021-07-09 11:24:46 -04:00
Gary Gregory b3daff2323 Better resource management. 2021-07-09 11:22:15 -04:00
Gary Gregory e06b8451f2 Better resource management. 2021-07-09 11:20:54 -04:00
Gary Gregory 5506bdb5cd Better name. 2021-07-09 11:19:41 -04:00
Gary Gregory f6f08321f6 Use Builder.
Don't declared unused exceptions in throw
2021-07-09 11:18:28 -04:00
Gary Gregory 5f605e613a Remove unused import. 2021-07-09 10:17:20 -04:00
Gary Gregory 5ccd1ed355 Update gitignore to ignore idea and vscode #160. 2021-07-09 10:08:26 -04:00
Seth Falco e40f9acaeb
chore: update gitignore to ignore idea and vscode (#160) 2021-07-09 10:07:26 -04:00
Gary Gregory 46bae4b99b Remove useless inline comments. 2021-07-08 20:18:51 -04:00
Gary Gregory ca5eb7cdbe Bump biz.aQute.bnd:biz.aQute.bndlib from 5.1.2 to 5.3.0. 2021-07-08 17:19:29 -04:00
Gary Gregory 171721ed35 Bump maven-javadoc-plugin from 3.2.0 to 3.3.0. 2021-07-08 17:16:26 -04:00
Gary Gregory f26a22a9a6 Test parsing an empty file.
- Sort members.
- Better constant name.
- Move RAT check to plugin management section to de-duplicate the
exclusion list.
2021-07-08 17:12:52 -04:00
Gary Gregory d608f55f0d File end in an EOL. 2021-07-08 15:29:46 -04:00
Gary Gregory ac280e705d [CSV-93] Allow the handling of NULL values.
- [CSV-253] Handle absent values in input (null).
- Cleaned up version of PR 77 from dota17 where:
- Don't duplicate two state items from the format.
- Use try-with-resources.
- Remove useless parens.
- Update Javaodc.
- Sort members in the new tests.
- Use builder.
2021-07-08 12:36:23 -04:00
Gary Gregory 4083b7a2a0 Use final. 2021-07-08 12:11:04 -04:00
Gary Gregory 6bfd380cb1 Use final. 2021-07-08 11:49:48 -04:00
Gary Gregory de4508c6c9 Replace JUnit assert by simpler but equivalent calls. #159. 2021-07-07 19:20:48 -04:00
Arturo Bernal c34e969d1e
Replace assert by simpler but equivalent calls. (#159) 2021-07-07 19:19:52 -04:00
Gary Gregory a4237345a1 [CSV-263] Print from Reader with embedded quotes generates incorrect
output.

- Resolve conflicts from PR #78 by Jason A. Guild.
- Don't use depreacted methods.
- Javadoc.
- Use final.
2021-07-07 19:18:12 -04:00
Gary Gregory 3dad2eef41 Refactor append calls into private methods for ongoing streaming work. 2021-07-07 18:59:07 -04:00
Gary Gregory 688e79c397 Bump junit-jupiter from 5.7.2 to 5.8.0-M1. 2021-07-07 18:50:29 -04:00
Gary Gregory 93a9affacf [CSV-158] Fix EOL checking for read array in ExtendedBufferedReader.
Clean up new test methods. Sort methods.
2021-07-07 08:43:55 -04:00
Alexander Bondarev a6ca4165a8
[CSV-158] Fix EOL checking for read array in ExtendedBufferedReader (#5)
* Fix eol checking for read array in ExtendedBufferedReader

* Add test for eol checking when reading to different buffers

Co-authored-by: mirasrael <d_signer@mail.ru>
Co-authored-by: Alexander Bondarev <alexander.bondarev@thomsonreuters.com>
2021-07-07 08:35:17 -04:00
Gary Gregory abfdf83f11 Add tests that print CSVRecords. 2021-07-06 13:11:43 -04:00
Gary Gregory d59f0866ce Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-csv.git 2021-07-06 09:37:04 -04:00
Gary Gregory 6d19cee13a Bump opencsv from 5.4 to 5.5 #158. 2021-07-06 09:36:57 -04:00
dependabot[bot] 472bafa9b6
Bump opencsv from 5.4 to 5.5 (#158)
Bumps opencsv from 5.4 to 5.5.

---
updated-dependencies:
- dependency-name: com.opencsv:opencsv
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-06 09:36:07 -04:00
Gary Gregory 589f822445 Use streams.
Remove unused imports.
2021-07-06 09:35:44 -04:00
Gary Gregory 9de125e4f1 Javadoc: Close HTML tags. 2021-07-05 16:39:58 -04:00
Gary Gregory c6c7676b56 Add PMD check to default goal and fix only 2 remaining PMD warnings. 2021-07-05 16:38:52 -04:00
Gary Gregory d8d080453e Add support for String delimiters #76.
Bump PMD core from 6.29.0 to 6.36.0. Fix rule set.
2021-07-05 12:06:07 -04:00
Gary Gregory b4b9a6bc0e Sort members. 2021-07-05 09:12:49 -04:00