Commit Graph

977 Commits

Author SHA1 Message Date
Sebastian Bazley 3294ed6721 CSV-117 Validate format parameters in constructor
Oops - another test case needs fixing

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603991 13f79535-47bb-0310-9956-ffa450edef68
2014-06-19 18:24:36 +00:00
Sebastian Bazley 3cd50672f7 CSV-117 Validate format parameters in constructor
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603967 13f79535-47bb-0310-9956-ffa450edef68
2014-06-19 17:28:22 +00:00
Sebastian Bazley f4cc9a928f Charset cannot be null
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603965 13f79535-47bb-0310-9956-ffa450edef68
2014-06-19 17:25:32 +00:00
Gary D. Gregory fcaa26799a Revert previous commit.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603206 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 15:50:53 +00:00
Gary D. Gregory 4b00469b22 Camel case.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603204 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 15:49:26 +00:00
Gary D. Gregory 04cee2bb14 Better error message in test.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603203 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 15:45:39 +00:00
Gary D. Gregory 52a57cba33 findbugs-maven-plugin 2.5.3 -> 2.5.4.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603169 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 13:52:45 +00:00
Gary D. Gregory 038de89639 commons-parent 34.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1603167 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 13:49:29 +00:00
Gary D. Gregory 30860d62bd Checkstyle: Line has trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602945 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 18:09:03 +00:00
Gary D. Gregory c1049b549b Use final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602944 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 18:07:45 +00:00
Gary D. Gregory 2076464484 class Lexer implements Closeable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602919 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 16:16:48 +00:00
Gary D. Gregory bfa592d06b Checkstyle: Line has trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602909 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:58:42 +00:00
Gary D. Gregory 32ffe82a5f Checkstyle: '+' should be on the previous line.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602908 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:53:11 +00:00
Gary D. Gregory cdbb1cd1a6 Checkstyle: '+' should be on the previous line.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602907 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:52:50 +00:00
Gary D. Gregory fa116dd46c Format "for".
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602906 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:50:14 +00:00
Gary D. Gregory 1fa12a6fc8 Checkstyle: Line is longer than 120 characters (found 141).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602904 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:48:40 +00:00
Gary D. Gregory 4b2a4caa30 Checkstyle: Line has trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602903 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:44:47 +00:00
Gary D. Gregory b993abb315 Checkstyle: Line has trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602902 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:43:51 +00:00
Gary D. Gregory 229b3b7691 org.apache.commons.csv.CSVParser.parse(File, Charset, CSVFormat) is now like org.apache.commons.csv.CSVParser.parse(URL, Charset, CSVFormat): You must pass in a Charset.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602901 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 15:39:52 +00:00
Gary D. Gregory 49579ec643 Forgot to make org.apache.commons.csv.CSVFormat.ignoreEmptyHeaders final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602242 13f79535-47bb-0310-9956-ffa450edef68
2014-06-12 17:33:12 +00:00
Gary D. Gregory 99c3819bec [CSV-121] Exception that the header contains duplicate names when the column names are empty. Added the setting ignoreEmptyHeaders, defaults to false to keep the IAE as the default behavior.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602206 13f79535-47bb-0310-9956-ffa450edef68
2014-06-12 15:38:24 +00:00
Gary D. Gregory f9871c5d35 [CSV-121] Exception that the header contains duplicate names when the column names are empty. Add a test that shows that TWO missing header is not OK.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602168 13f79535-47bb-0310-9956-ffa450edef68
2014-06-12 13:59:33 +00:00
Gary D. Gregory 5a9436d462 [CSV-121] Exception that the header contains duplicate names when the column names are empty. Add a test that shows that ONE missing header is OK.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1602166 13f79535-47bb-0310-9956-ffa450edef68
2014-06-12 13:57:48 +00:00
Gary D. Gregory 1282503fb9 <action issue="CSV-120" type="add" dev="ggregory" due-to="Sergei Lebedev">CSVFormat#withHeader doesn't work with CSVPrinter</action>
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1601517 13f79535-47bb-0310-9956-ffa450edef68
2014-06-09 22:21:22 +00:00
Gary D. Gregory 65f110ec14 <action issue="CSV-119" type="add" dev="ggregory" due-to="Sergei Lebedev">CSVFormat is missing a print(...) method</action>
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1599285 13f79535-47bb-0310-9956-ffa450edef68
2014-06-02 18:04:49 +00:00
Gary D. Gregory 2480dffa6d <action issue="CSV-118" type="fix" dev="ggregory" due-to="Enrique Lara">CSVRecord.toMap() throws NPE on formats with no headers.</action>
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1594966 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 16:26:26 +00:00
Gary D. Gregory 0331565fba Format with 2 spaces per XML indent and 120 chars line width.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1594965 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 16:24:56 +00:00
Sebastian Bazley 88a7e755e6 CSV-113 Check whether ISE/IAE are being used appropriately
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1593148 13f79535-47bb-0310-9956-ffa450edef68
2014-05-07 22:12:56 +00:00
Sebastian Bazley 16b175b01a tab police
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1593097 13f79535-47bb-0310-9956-ffa450edef68
2014-05-07 18:12:10 +00:00
Sebastian Bazley 7945a4f24c Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1593094 13f79535-47bb-0310-9956-ffa450edef68
2014-05-07 18:09:06 +00:00
Sebastian Bazley 35d101c2ad CSV-114 CSVFormat constructor should reject a header array with duplicate entries
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1593076 13f79535-47bb-0310-9956-ffa450edef68
2014-05-07 17:27:31 +00:00
Benedikt Ritter 692a1e362d Make CSVFormat constructor package private since it is only used in CSVFormat.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592833 13f79535-47bb-0310-9956-ffa450edef68
2014-05-06 18:37:15 +00:00
Benedikt Ritter 4698a563dc Add missing fields to hashcode and equals methods
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592832 13f79535-47bb-0310-9956-ffa450edef68
2014-05-06 18:32:38 +00:00
Benedikt Ritter 3e8fe990dd Add some pointers for contirbutors
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592830 13f79535-47bb-0310-9956-ffa450edef68
2014-05-06 18:24:17 +00:00
Benedikt Ritter 85226d80e6 CSV-115: Simplify boolean expressions in CSVRecord. This also closes #1 from github. Thanks to Furkan Kamaci.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592822 13f79535-47bb-0310-9956-ffa450edef68
2014-05-06 18:11:37 +00:00
Sebastian Bazley a3260ed930 Avoid IDE warning
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592639 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 22:03:17 +00:00
Benedikt Ritter d030030d3d Shamelessly steal the support section from commons lang
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592616 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 19:26:41 +00:00
Benedikt Ritter ac1e5a4486 Correct indentation of new TagList config
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592612 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 19:07:11 +00:00
Benedikt Ritter 6981b1110b Drop deprecated configuration of TagList plugin and replace it with a finer grained configuration provided by Brend Eckenfels
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592610 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 19:01:29 +00:00
Benedikt Ritter c08219e0d7 Document reliance of parse(File, CSVFormat) to default encoding
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592604 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 18:45:55 +00:00
Benedikt Ritter 129a8db75e Remove obsolete comment
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592603 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 18:45:29 +00:00
Benedikt Ritter 07a73d2824 Fix checkstyle error
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592600 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 18:36:31 +00:00
Benedikt Ritter 4e89209720 Update checkstyle version
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592598 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 18:36:16 +00:00
Benedikt Ritter a3da0a7a5a CSV now has it's own jira project
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592596 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 18:25:33 +00:00
Benedikt Ritter 7d51af9404 Make checkstyle happy (line is longer than 120 characters)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592382 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 17:01:07 +00:00
Benedikt Ritter 2fdf2c8a19 Document all fixed issues
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592380 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 16:58:53 +00:00
Benedikt Ritter ce4e72701b CSV-112: HeaderMap is inconsistent when it is parsed from an input with duplicate columns names. Reported by Romain Gossé
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592371 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 16:22:34 +00:00
Benedikt Ritter c84328e64a Fix JavaDoc errors
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1592365 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 16:08:56 +00:00
Gary D. Gregory 9f03b06a1e [CSV-111] CSVRecord.toMap() fails if row length shorter than header length.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1589281 13f79535-47bb-0310-9956-ffa450edef68
2014-04-22 20:20:17 +00:00
Gary D. Gregory a84668e0ea Revert.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1585716 13f79535-47bb-0310-9956-ffa450edef68
2014-04-08 13:02:01 +00:00