e2f0a4d8a8
* CSV-252 Stop using junit.framework.TestCase
junit.framework.TestCase is a class from JUnit 3, and while it is not
officially deprecated, it's discouraged to use it.
This patch removes the single use of
junit.framework.TestCase#assertNull, and replaces it with the
standard, recommended, org.junit.Assert#assertNull.
* CSV-252 Standardize org.junit.Assert imports
Code in the project uses org.junit.Assert's methods in two ways:
1. By statically importing them
2. By importing the class and using its methods
Option 1 seems to be the de-facto standard, with just a handful of
cases using Option 2.
This patch standardizes these cases to also use static imports thus
making the code look more uniform, and easier to maintain.
* CSV-252 Upgrade Mockito to 3.1.0
Upgrade the Mockito dependency to the latest available version, 3.1.0,
in order to facilitate an upgrade to JUnit Jupiter.
* CSV-252 JUnit Jupiter upgrade
This patch upgrades the project's testing framework from JUnit 4.12
to the modern JUnit Jupiter 5.5.4.
Since JUnit 5 Jupiter is not backwards compatible to JUnit 4.x (or
even JUnit Vintage), this patch is a bit large, even though a lot of
the changes are merely cosmetic (such as changing the argument order,
see details below). In order to make the reviewer's task as easy as
possible, this PR does not presume to use JUnit Jupiter's best
practices and all its new functionality, but only to migrate the
existing tests with as little change as possible. Following patches
may want to improve the tests by using some of JUnit Jupiter's new
features.
This patch includes the following changes:
1. Maven dependency changes:
a. junit:junit was replaced with org.junit.jupiter:junit-jupiter.
b. org.hamcrest:hamcrest was introduced as an explicit dependency,
since the project uses Hamcrest, and JUnit Jupiter does not
bundle Hamcrest, unlike JUnit 4.x.
2. Annotations:
a. org.junit.jupiter.api.Test was used as a drop in replacement for
org.juit.Test without arguments. See 3.ii. for handling of @Test
annotations with an "expected" argument.
b. org.junit.jupiter.api.BeforeEach was used as an drop in
replacement for org.junit.Before.
c. org.junit.jupiter.api.BeforeAll was used as an drop in
replacement for org.junit.BeforeClass.
d. org.junit.jupiter.api.Disabled was used as a drop in replacement
for org.junit.Ignore.
3. Assertions:
a. org.junit.jupiter.api.Assertions' methods were used as drop in
replacements for org.junit.Assert's methods with the same name in
the simple case of an assertion without a message. In the case of
an assertion with a message, org.junit.jupiter.api.Assertions'
methods were used, but the argument order was changed - Assert's
methods take the message as the first argument, while Assertions'
methods take the message as the last argument.
b. org.junit.jupiter.api.Assertions#assertThrows was used to assert
that a specific exception was throws instead of an org.junit.Test
annotation with an expected argument. This technique has a couple
of side bonuses. First, it makes the tests slightly stricter, as
now they can assert the exception was thrown from a specific line
and prevent false positives where the test's "set-up" code
accidentally threw that exception. Second, it clarifies that some
of the test code is unreachable (as a previous line already
throws an exception), and can safely be removed in order to clean
up the test. The throws clauses of these methods were cleaned up
from exceptions that can no longer be thrown in order to avoid
compilation warnings.
c. org.hamcrest.MatcherAssert#assertThat was used as a drop in
replacement for org.junit.Assert#assertThat.
4. Specific Changes:
a. CSVFileParserTest was rewritten with JUnit Jupiter's
org.junit.jupiter.api.ParameterizedTest. Unlike JUnit 4's
org.junit.runners.Parameterized, it cannot be used to inject
arguments to a test's construct, and so the test can't be
stateful. Instead, it was rewritten so every test receives the
file as a parameter, and opens a reader on it itself. As a side
bonus, this design makes it easier to close the reader and avoid
leaving open file descriptors like the original test did.
|
||
|---|---|---|
| src | ||
| .gitignore | ||
| .travis.yml | ||
| CONTRIBUTING.md | ||
| LICENSE-header.txt | ||
| LICENSE.txt | ||
| NOTICE.txt | ||
| README.md | ||
| RELEASE-NOTES.txt | ||
| checkstyle.xml | ||
| pom.xml | ||
README.md
Apache Commons CSV
The Apache Commons CSV library provides a simple interface for reading and writing CSV files of various types.
Documentation
More information can be found on the Apache Commons CSV homepage. The Javadoc can be browsed. Questions related to the usage of Apache Commons CSV should be posted to the user mailing list.
Where can I get the latest release?
You can download source and binaries from our download page.
Alternatively you can pull it from the central Maven repositories:
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-csv</artifactId>
<version>1.7</version>
</dependency>
Contributing
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors. There are some guidelines which will make applying PRs easier for us:
- No tabs! Please use spaces for indentation.
- Respect the code style.
- Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
- Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running
mvn clean test.
If you plan to contribute on a regular basis, please consider filing a contributor license agreement. You can learn more about contributing via GitHub in our contribution guidelines.
License
This code is under the Apache Licence v2.
See the NOTICE.txt file for required notices and attributions.
Donations
You like Apache Commons CSV? Then donate back to the ASF to support the development.
Additional Resources
- Apache Commons Homepage
- Apache Issue Tracker (JIRA)
- Apache Commons Twitter Account
#apache-commonsIRC channel onirc.freenode.org