From 01067903aaa19b633836728922c5c215c4f9b5f4 Mon Sep 17 00:00:00 2001 From: Sebastian Bazley Date: Sat, 16 Jan 2010 13:05:07 +0000 Subject: [PATCH] LANG-571 ArrayUtils.add(T[] array[, offset], T element) can create unexpected ClassCastException Remove tests for generation of Object arrays when both objects are null git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@899940 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/commons/lang3/ArrayUtilsAddTest.java | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java index 8d2e0e169..162acbf91 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java @@ -178,15 +178,8 @@ public void testAddObjectArrayShort() { public void testAddObjectArrayObject() { Object[] newArray; - newArray = ArrayUtils.add((Object[])null, null); - assertTrue(Arrays.equals((new Object[]{null}), newArray)); - assertEquals(Object.class, newArray.getClass().getComponentType()); //show that not casting is okay - newArray = ArrayUtils.add(null, null); - assertTrue(Arrays.equals((new Object[]{null}), newArray)); - assertEquals(Object.class, newArray.getClass().getComponentType()); - newArray = ArrayUtils.add((Object[])null, "a"); assertTrue(Arrays.equals((new String[]{"a"}), newArray)); assertTrue(Arrays.equals((new Object[]{"a"}), newArray)); @@ -216,10 +209,6 @@ public void testAddObjectArrayObject() { newArray = ArrayUtils.add(numberArray1, new Float(3)); assertTrue(Arrays.equals((new Float[]{new Float(3)}), newArray)); assertEquals(Float.class, newArray.getClass().getComponentType()); - - newArray = ArrayUtils.add(numberArray1, null); - assertTrue(Arrays.equals((new Object[]{null}), newArray)); - assertEquals(Object.class, newArray.getClass().getComponentType()); } public void testLANG571(){ @@ -360,9 +349,6 @@ public void testAddObjectArrayToObjectArray() { public void testAddObjectAtIndex() { Object[] newArray; - newArray = ArrayUtils.add((Object[])null, 0, null); - assertTrue(Arrays.equals((new Object[]{null}), newArray)); - assertEquals(Object.class, newArray.getClass().getComponentType()); newArray = ArrayUtils.add((Object[])null, 0, "a"); assertTrue(Arrays.equals((new String[]{"a"}), newArray)); assertTrue(Arrays.equals((new Object[]{"a"}), newArray));