From 0d828cd0754202525617edc99e8bfc3395c7beb7 Mon Sep 17 00:00:00 2001 From: Matthew Jason Benson Date: Thu, 4 Feb 2010 22:10:24 +0000 Subject: [PATCH] unused imports + uh, why would you synchronize access to a ThreadLocal? :P git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@906682 13f79535-47bb-0310-9956-ffa450edef68 --- .../commons/lang3/builder/ToStringStyle.java | 26 +++++++------------ 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java index 26214ed41..06cb55b8a 100644 --- a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java +++ b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java @@ -19,9 +19,7 @@ import java.io.Serializable; import java.lang.reflect.Array; import java.util.Collection; -import java.util.Collections; import java.util.Map; -import java.util.Set; import java.util.WeakHashMap; import org.apache.commons.lang3.ClassUtils; @@ -175,13 +173,10 @@ static boolean isRegistered(Object value) { */ static void register(Object value) { if (value != null) { - WeakHashMap m; - synchronized (ToStringStyle.class) { - m = REGISTRY.get(); - if (m == null) { - m = new WeakHashMap(); - REGISTRY.set(m); - } + WeakHashMap m = REGISTRY.get(); + if (m == null) { + m = new WeakHashMap(); + REGISTRY.set(m); } m.put(value, null); } @@ -201,14 +196,11 @@ static void register(Object value) { */ static void unregister(Object value) { if (value != null) { - WeakHashMap m; - synchronized (ToStringStyle.class) { - m = REGISTRY.get(); - if (m != null) { - m.remove(value); - if (m.isEmpty()) { - REGISTRY.remove(); - } + WeakHashMap m = REGISTRY.get(); + if (m != null) { + m.remove(value); + if (m.isEmpty()) { + REGISTRY.remove(); } } }