From 123029804473d1817d8c303075e1733eff756b40 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Mon, 7 Mar 2022 15:35:51 -0500 Subject: [PATCH] Unnecessary @SuppressWarnings("unchecked") --- .../lang3/concurrent/ConcurrentUtilsTest.java | 88 ++++++------------- 1 file changed, 26 insertions(+), 62 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java b/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java index 1e20c49b4..218d61c3d 100644 --- a/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java @@ -107,8 +107,7 @@ public class ConcurrentUtilsTest { @Test public void testExtractCauseError() { final Error err = new AssertionError("Test"); - final AssertionError e = - assertThrows(AssertionError.class, () -> ConcurrentUtils.extractCause(new ExecutionException(err))); + final AssertionError e = assertThrows(AssertionError.class, () -> ConcurrentUtils.extractCause(new ExecutionException(err))); assertEquals(err, e, "Wrong error"); } @@ -127,8 +126,7 @@ public class ConcurrentUtilsTest { @Test public void testExtractCauseChecked() { final Exception ex = new Exception("Test"); - final ConcurrentException cex = ConcurrentUtils - .extractCause(new ExecutionException(ex)); + final ConcurrentException cex = ConcurrentUtils.extractCause(new ExecutionException(ex)); assertSame(ex, cex.getCause(), "Wrong cause"); } @@ -164,8 +162,7 @@ public class ConcurrentUtilsTest { @Test public void testExtractCauseUncheckedUncheckedException() { final RuntimeException rex = new RuntimeException("Test"); - final RuntimeException r = - assertThrows(RuntimeException.class, () -> ConcurrentUtils.extractCauseUnchecked(new ExecutionException(rex))); + final RuntimeException r = assertThrows(RuntimeException.class, () -> ConcurrentUtils.extractCauseUnchecked(new ExecutionException(rex))); assertEquals(rex, r, "Wrong exception"); } @@ -175,8 +172,7 @@ public class ConcurrentUtilsTest { @Test public void testExtractCauseUncheckedChecked() { final Exception ex = new Exception("Test"); - final ConcurrentRuntimeException cex = ConcurrentUtils - .extractCauseUnchecked(new ExecutionException(ex)); + final ConcurrentRuntimeException cex = ConcurrentUtils.extractCauseUnchecked(new ExecutionException(ex)); assertSame(ex, cex.getCause(), "Wrong cause"); } @@ -196,8 +192,7 @@ public class ConcurrentUtilsTest { @Test public void testHandleCauseUncheckedException() { final RuntimeException rex = new RuntimeException("Test"); - final RuntimeException r = - assertThrows(RuntimeException.class, () -> ConcurrentUtils.handleCause(new ExecutionException(rex))); + final RuntimeException r = assertThrows(RuntimeException.class, () -> ConcurrentUtils.handleCause(new ExecutionException(rex))); assertEquals(rex, r, "Wrong exception"); } @@ -207,15 +202,13 @@ public class ConcurrentUtilsTest { @Test public void testHandleCauseChecked() { final Exception ex = new Exception("Test"); - final ConcurrentException cex = - assertThrows(ConcurrentException.class, () -> ConcurrentUtils.handleCause(new ExecutionException(ex))); + final ConcurrentException cex = assertThrows(ConcurrentException.class, () -> ConcurrentUtils.handleCause(new ExecutionException(ex))); assertEquals(ex, cex.getCause(), "Wrong cause"); } /** - * Tests handleCause() for a null parameter or a null cause. In this case - * the method should do nothing. We can only test that no exception is - * thrown. + * Tests handleCause() for a null parameter or a null cause. In this case the method should do nothing. We can only test + * that no exception is thrown. * * @throws org.apache.commons.lang3.concurrent.ConcurrentException so we don't have to catch it */ @@ -241,8 +234,7 @@ public class ConcurrentUtilsTest { @Test public void testHandleCauseUncheckedUncheckedException() { final RuntimeException rex = new RuntimeException("Test"); - final RuntimeException r = - assertThrows(RuntimeException.class, () -> ConcurrentUtils.handleCauseUnchecked(new ExecutionException(rex))); + final RuntimeException r = assertThrows(RuntimeException.class, () -> ConcurrentUtils.handleCauseUnchecked(new ExecutionException(rex))); assertEquals(rex, r, "Wrong exception"); } @@ -252,21 +244,19 @@ public class ConcurrentUtilsTest { @Test public void testHandleCauseUncheckedChecked() { final Exception ex = new Exception("Test"); - final ConcurrentRuntimeException crex = - assertThrows(ConcurrentRuntimeException.class, () -> ConcurrentUtils.handleCauseUnchecked(new ExecutionException(ex))); + final ConcurrentRuntimeException crex = assertThrows(ConcurrentRuntimeException.class, + () -> ConcurrentUtils.handleCauseUnchecked(new ExecutionException(ex))); assertEquals(ex, crex.getCause(), "Wrong cause"); } /** - * Tests handleCauseUnchecked() for a null parameter or a null cause. In - * this case the method should do nothing. We can only test that no - * exception is thrown. + * Tests handleCauseUnchecked() for a null parameter or a null cause. In this case the method should do nothing. We can + * only test that no exception is thrown. */ @Test public void testHandleCauseUncheckedNull() { ConcurrentUtils.handleCauseUnchecked(null); - ConcurrentUtils.handleCauseUnchecked(new ExecutionException("Test", - null)); + ConcurrentUtils.handleCauseUnchecked(new ExecutionException("Test", null)); } /** @@ -286,10 +276,7 @@ public class ConcurrentUtilsTest { */ @Test public void testInitialize() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); final Object result = new Object(); EasyMock.expect(init.get()).andReturn(result); EasyMock.replay(init); @@ -320,10 +307,7 @@ public class ConcurrentUtilsTest { */ @Test public void testInitializeUnchecked() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); final Object result = new Object(); EasyMock.expect(init.get()).andReturn(result); EasyMock.replay(init); @@ -338,15 +322,11 @@ public class ConcurrentUtilsTest { */ @Test public void testInitializeUncheckedEx() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); final Exception cause = new Exception(); EasyMock.expect(init.get()).andThrow(new ConcurrentException(cause)); EasyMock.replay(init); - final ConcurrentRuntimeException crex = - assertThrows(ConcurrentRuntimeException.class, () -> ConcurrentUtils.initializeUnchecked(init)); + final ConcurrentRuntimeException crex = assertThrows(ConcurrentRuntimeException.class, () -> ConcurrentUtils.initializeUnchecked(init)); assertSame(cause, crex.getCause(), "Wrong cause"); EasyMock.verify(init); } @@ -427,10 +407,7 @@ public class ConcurrentUtilsTest { */ @Test public void testCreateIfAbsentKeyPresent() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); EasyMock.replay(init); final String key = "testKey"; final Integer value = 42; @@ -448,10 +425,7 @@ public class ConcurrentUtilsTest { */ @Test public void testCreateIfAbsentKeyNotPresent() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); final String key = "testKey"; final Integer value = 42; EasyMock.expect(init.get()).andReturn(value); @@ -469,10 +443,7 @@ public class ConcurrentUtilsTest { */ @Test public void testCreateIfAbsentNullMap() throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); EasyMock.replay(init); assertNull(ConcurrentUtils.createIfAbsent(null, "test", init), "Wrong result"); EasyMock.verify(init); @@ -501,8 +472,7 @@ public class ConcurrentUtilsTest { final String key = "testKey"; final Integer value = 42; final ConcurrentMap map = new ConcurrentHashMap<>(); - assertEquals(value, ConcurrentUtils.createIfAbsentUnchecked(map, key, new ConstantInitializer<>(value)), - "Wrong result"); + assertEquals(value, ConcurrentUtils.createIfAbsentUnchecked(map, key, new ConstantInitializer<>(value)), "Wrong result"); assertEquals(value, map.get(key), "Wrong value in map"); } @@ -512,19 +482,13 @@ public class ConcurrentUtilsTest { * @throws org.apache.commons.lang3.concurrent.ConcurrentException so we don't have to catch it */ @Test - public void testCreateIfAbsentUncheckedException() - throws ConcurrentException { - @SuppressWarnings("unchecked") - final - ConcurrentInitializer init = EasyMock - .createMock(ConcurrentInitializer.class); + public void testCreateIfAbsentUncheckedException() throws ConcurrentException { + final ConcurrentInitializer init = EasyMock.createMock(ConcurrentInitializer.class); final Exception ex = new Exception(); EasyMock.expect(init.get()).andThrow(new ConcurrentException(ex)); EasyMock.replay(init); - final ConcurrentRuntimeException crex = - assertThrows( - ConcurrentRuntimeException.class, - () -> ConcurrentUtils.createIfAbsentUnchecked(new ConcurrentHashMap<>(), "test", init)); + final ConcurrentRuntimeException crex = assertThrows(ConcurrentRuntimeException.class, + () -> ConcurrentUtils.createIfAbsentUnchecked(new ConcurrentHashMap<>(), "test", init)); assertEquals(ex, crex.getCause(), "Wrong cause"); EasyMock.verify(init); }