Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use StandardCharsets instead of magic string

This commit is contained in:
Gary Gregory 2023-12-15 16:26:58 -05:00
parent fc0bb1464c
commit 16a826adc6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/java/org/apache/commons/lang3/StringUtilsTest.java
View File

@ -3037,7 +3037,7 @@ public class StringUtilsTest extends AbstractLangTest {
// sanity check end // sanity check end
assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.defaultCharset())); assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.defaultCharset()));
assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.forName(encoding))); assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.forName(encoding)));
encoding = "UTF-16"; encoding = StandardCharsets.UTF_16.name();
expectedBytes = expectedString.getBytes(Charset.forName(encoding)); expectedBytes = expectedString.getBytes(Charset.forName(encoding));
assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.forName(encoding))); assertEquals(expectedString, StringUtils.toEncodedString(expectedBytes, Charset.forName(encoding)));
} }
@ -3097,7 +3097,7 @@ public class StringUtilsTest extends AbstractLangTest {
// sanity check end // sanity check end
assertEquals(expectedString, StringUtils.toString(expectedBytes, null)); assertEquals(expectedString, StringUtils.toString(expectedBytes, null));
assertEquals(expectedString, StringUtils.toString(expectedBytes, SystemUtils.FILE_ENCODING)); assertEquals(expectedString, StringUtils.toString(expectedBytes, SystemUtils.FILE_ENCODING));
final String encoding = "UTF-16"; final String encoding = StandardCharsets.UTF_16.name();
expectedBytes = expectedString.getBytes(Charset.forName(encoding)); expectedBytes = expectedString.getBytes(Charset.forName(encoding));
assertEquals(expectedString, StringUtils.toString(expectedBytes, encoding)); assertEquals(expectedString, StringUtils.toString(expectedBytes, encoding));
} }