From 3942fad3c25f5f56109c7db6f8edbb6a6a20e09a Mon Sep 17 00:00:00 2001 From: Roland Kreuzer <36326488+rolandkreuzer@users.noreply.github.com> Date: Sat, 30 Oct 2021 14:58:48 +0200 Subject: [PATCH 1/2] [LANG-1664] Adjust doc to show argument is a primitive integer / character code point --- src/main/java/org/apache/commons/lang3/StringUtils.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index cc4232011..a2c26d4e3 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -8589,7 +8589,7 @@ public class StringUtils { * * * @param str the String to get a substring from, may be null - * @param separator the character to search. + * @param separator the character (Unicode code point) to search. * @return the substring after the first occurrence of the separator, * {@code null} if null String input * @since 3.11 @@ -8668,7 +8668,7 @@ public class StringUtils { * * * @param str the String to get a substring from, may be null - * @param separator the String to search for, may be null + * @param separator the character (Unicode code point) to search. * @return the substring after the last occurrence of the separator, * {@code null} if null String input * @since 3.11 @@ -8750,7 +8750,7 @@ public class StringUtils { * * * @param str the String to get a substring from, may be null - * @param separator the String to search for, may be null + * @param separator the character (Unicode code point) to search. * @return the substring before the first occurrence of the separator, {@code null} if null String input * @since 3.12.0 */ From 391d51055b8fb50375bf6a0b3d0098a7c1bb1d80 Mon Sep 17 00:00:00 2001 From: "Bruno P. Kinoshita" Date: Sun, 31 Oct 2021 11:58:44 +1300 Subject: [PATCH 2/2] [LANG-1664] Changelog --- src/changes/changes.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 084aa1d54..033b1a3fe 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -108,6 +108,7 @@ The type attribute can be add,update,fix,remove. Bump maven-pmd-plugin from 3.14.0 to 3.15.0 #802. Bump biz.aQute.bndlib from 5.3.0 to 6.0.0 #814. Bump actions/checkout from 2.3.4 to 2.3.5 #819. + Javadoc for StringUtils.substringBefore(String str, int separator) doesn't mention that the separator is an int.