Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LANG-1252: adding more isNumber Tests before full deletion of method

This commit is contained in:
Rob Tompkins 2016-09-11 11:02:01 -04:00
parent b3c31a379e
commit 204ed0048f
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
View File

@ -1376,6 +1376,40 @@ public class NumberUtilsTest {
compareIsNumberWithCreateNumber("1.1L", false); // LANG-664
}
@Test
public void testIsNumberLANG971() {
compareIsNumberWithCreateNumber("0085", false);
compareIsNumberWithCreateNumber("085", false);
compareIsNumberWithCreateNumber("08", false);
compareIsNumberWithCreateNumber("07", true);
compareIsNumberWithCreateNumber("00", true);
}
@Test
public void testIsNumberLANG992() {
compareIsNumberWithCreateNumber("0.0", true);
compareIsNumberWithCreateNumber("0.4790", true);
}
@Test
public void testIsNumberLANG972() {
compareIsNumberWithCreateNumber("0xABCD", true);
compareIsNumberWithCreateNumber("0XABCD", true);
}
@Test
public void testIsNumberLANG1252() {
//Check idiosyncries between java 1.6 and 1.7,1.8 redarding leading + signs
if (SystemUtils.IS_JAVA_1_6) {
compareIsNumberWithCreateNumber("+2", false);
} else {
compareIsNumberWithCreateNumber("+2", true);
}
//The Following should work regardless of 1.6, 1.7, or 1.8
compareIsNumberWithCreateNumber("+2.0", true);
}
private void compareIsNumberWithCreateNumber(final String val, final boolean expected) {
final boolean isValid = NumberUtils.isNumber(val);
final boolean canCreate = checkCreateNumber(val);