Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Must not use autoboxing for Booleans in toBooleanObject(String), as we rely on object equality in toBoolean(String) 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@966170 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2010-07-21 10:47:20 +00:00
parent 31ada5ec5b
commit 228995f61a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/org/apache/commons/lang3/BooleanUtils.java
View File

@ -563,12 +563,12 @@ public static Boolean toBooleanObject(String str) {
if ((ch0 == 'o' || ch0 == 'O') &&
(ch1 == 'n' || ch1 == 'N') )
{
return true;
return Boolean.TRUE;
}
if ((ch0 == 'n' || ch0 == 'N') &&
(ch1 == 'o' || ch1 == 'O') )
{
return false;
return Boolean.FALSE;
}
break;
}
@ -580,13 +580,13 @@ public static Boolean toBooleanObject(String str) {
(ch1 == 'e' || ch1 == 'E') &&
(ch2 == 's' || ch2 == 'S') )
{
return true;
return Boolean.TRUE;
}
if ((ch0 == 'o' || ch0 == 'O') &&
(ch1 == 'f' || ch1 == 'F') &&
(ch2 == 'f' || ch2 == 'F') )
{
return false;
return Boolean.FALSE;
}
break;
}
@ -600,7 +600,7 @@ public static Boolean toBooleanObject(String str) {
(ch2 == 'u' || ch2 == 'U') &&
(ch3 == 'e' || ch3 == 'E') )
{
return true;
return Boolean.TRUE;
}
break;
}
@ -616,7 +616,7 @@ public static Boolean toBooleanObject(String str) {
(ch3 == 's' || ch3 == 'S') &&
(ch4 == 'e' || ch4 == 'E') )
{
return false;
return Boolean.FALSE;
}
break;
}