From 255db44501865a41f9f4082e73ac085ab99eb4b5 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Mon, 14 Aug 2023 08:40:15 -0400 Subject: [PATCH] Better assert message --- .../lang3/time/FastDateParser_TimeZoneStrategyTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java b/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java index 9ce6d899f..d990f5ddf 100644 --- a/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java +++ b/src/test/java/org/apache/commons/lang3/time/FastDateParser_TimeZoneStrategyTest.java @@ -125,9 +125,9 @@ public class FastDateParser_TimeZoneStrategyTest extends AbstractLangTest { } catch (ParseException e) { failCount++; // Missing "Zulu" or something else in broken JDK's GH builds? - parseExceptionList.add(new AssertionFailedError( - String.format("%s: with tzDefault = %s, locale = %s, zones[][] size = '%s', zIndex = %,d, tzDisplay = '%s', parser = '%s'", e, - timeZone, locale, zone.length, zIndex, tzDisplay, parser.toStringAll()), + final String msg = String.format("%s: with tzDefault = %s, locale = %s, zones[][] size = '%s', zIndex = %,d, tzDisplay = '%s', parser = '%s'", e, + timeZone, locale, zone.length, zIndex, tzDisplay, parser.toStringAll()); + parseExceptionList.add(new AssertionFailedError(msg, e)); // HACK check if (failCount > 43) { @@ -140,7 +140,7 @@ public class FastDateParser_TimeZoneStrategyTest extends AbstractLangTest { Stream.of(zones).forEach(zoneArray -> zonesPs.printf("[%,d] %s%n", i.getAndIncrement(), Arrays.toString(zoneArray))); System.err.println(zonesOut); System.err.println(parseExceptionList); - fail(e); + fail(String.format("failCount = %,d, %s", failCount, msg), e); } } }