PMD: Useless parentheses
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1671675 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
2bc2ffde1f
commit
35f1cc0027
|
@ -190,9 +190,9 @@ public static boolean isSameDay(final Calendar cal1, final Calendar cal2) {
|
||||||
if (cal1 == null || cal2 == null) {
|
if (cal1 == null || cal2 == null) {
|
||||||
throw new IllegalArgumentException("The date must not be null");
|
throw new IllegalArgumentException("The date must not be null");
|
||||||
}
|
}
|
||||||
return (cal1.get(Calendar.ERA) == cal2.get(Calendar.ERA) &&
|
return cal1.get(Calendar.ERA) == cal2.get(Calendar.ERA) &&
|
||||||
cal1.get(Calendar.YEAR) == cal2.get(Calendar.YEAR) &&
|
cal1.get(Calendar.YEAR) == cal2.get(Calendar.YEAR) &&
|
||||||
cal1.get(Calendar.DAY_OF_YEAR) == cal2.get(Calendar.DAY_OF_YEAR));
|
cal1.get(Calendar.DAY_OF_YEAR) == cal2.get(Calendar.DAY_OF_YEAR);
|
||||||
}
|
}
|
||||||
|
|
||||||
//-----------------------------------------------------------------------
|
//-----------------------------------------------------------------------
|
||||||
|
@ -249,14 +249,14 @@ public static boolean isSameLocalTime(final Calendar cal1, final Calendar cal2)
|
||||||
if (cal1 == null || cal2 == null) {
|
if (cal1 == null || cal2 == null) {
|
||||||
throw new IllegalArgumentException("The date must not be null");
|
throw new IllegalArgumentException("The date must not be null");
|
||||||
}
|
}
|
||||||
return (cal1.get(Calendar.MILLISECOND) == cal2.get(Calendar.MILLISECOND) &&
|
return cal1.get(Calendar.MILLISECOND) == cal2.get(Calendar.MILLISECOND) &&
|
||||||
cal1.get(Calendar.SECOND) == cal2.get(Calendar.SECOND) &&
|
cal1.get(Calendar.SECOND) == cal2.get(Calendar.SECOND) &&
|
||||||
cal1.get(Calendar.MINUTE) == cal2.get(Calendar.MINUTE) &&
|
cal1.get(Calendar.MINUTE) == cal2.get(Calendar.MINUTE) &&
|
||||||
cal1.get(Calendar.HOUR_OF_DAY) == cal2.get(Calendar.HOUR_OF_DAY) &&
|
cal1.get(Calendar.HOUR_OF_DAY) == cal2.get(Calendar.HOUR_OF_DAY) &&
|
||||||
cal1.get(Calendar.DAY_OF_YEAR) == cal2.get(Calendar.DAY_OF_YEAR) &&
|
cal1.get(Calendar.DAY_OF_YEAR) == cal2.get(Calendar.DAY_OF_YEAR) &&
|
||||||
cal1.get(Calendar.YEAR) == cal2.get(Calendar.YEAR) &&
|
cal1.get(Calendar.YEAR) == cal2.get(Calendar.YEAR) &&
|
||||||
cal1.get(Calendar.ERA) == cal2.get(Calendar.ERA) &&
|
cal1.get(Calendar.ERA) == cal2.get(Calendar.ERA) &&
|
||||||
cal1.getClass() == cal2.getClass());
|
cal1.getClass() == cal2.getClass();
|
||||||
}
|
}
|
||||||
|
|
||||||
//-----------------------------------------------------------------------
|
//-----------------------------------------------------------------------
|
||||||
|
@ -1019,7 +1019,7 @@ private static void modify(final Calendar val, final int field, final ModifyType
|
||||||
for (final int element : aField) {
|
for (final int element : aField) {
|
||||||
if (element == field) {
|
if (element == field) {
|
||||||
//This is our field... we stop looping
|
//This is our field... we stop looping
|
||||||
if (modType == ModifyType.CEILING || (modType == ModifyType.ROUND && roundUp)) {
|
if (modType == ModifyType.CEILING || modType == ModifyType.ROUND && roundUp) {
|
||||||
if (field == DateUtils.SEMI_MONTH) {
|
if (field == DateUtils.SEMI_MONTH) {
|
||||||
//This is a special case that's hard to generalize
|
//This is a special case that's hard to generalize
|
||||||
//If the date is 1, we round up to 16, otherwise
|
//If the date is 1, we round up to 16, otherwise
|
||||||
|
|
Loading…
Reference in New Issue