Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Extract formatting tests of time zones into parameterized test 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1666577 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Benedikt Ritter 2015-03-13 21:00:37 +00:00
parent 04c8de2334
commit 442e8c2705
2 changed files with 49 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
View File

@ -260,26 +260,6 @@ public void testTimeZoneMatches() {
assertEquals(NEW_YORK, printer.getTimeZone());
}
@Test
public void testCalendarTimezoneRespected() {
final String[] availableZones = TimeZone.getAvailableIDs();
for (final String zone : availableZones) {
TimeZone anotherZone = TimeZone.getTimeZone(zone);
assertNotNull("Cannot find another timezone", anotherZone);
final String pattern = "h:mma z";
final Calendar cal = Calendar.getInstance(anotherZone);
final SimpleDateFormat sdf = new SimpleDateFormat(pattern);
sdf.setTimeZone(anotherZone);
final String expectedValue = sdf.format(cal.getTime());
final String actualValue = FastDateFormat.getInstance(pattern).format(cal);
assertEquals(expectedValue, actualValue);
}
}
@Test
public void testTimeZoneAsZ() throws Exception {
Calendar c = Calendar.getInstance(TimeZone.getTimeZone("UTC"));

49
src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java Normal file
View File

@ -0,0 +1,49 @@
package org.apache.commons.lang3.time;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Collection;
import java.util.List;
import java.util.TimeZone;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@RunWith(Parameterized.class)
public class FastDatePrinterTimeZonesTest {
private static final String PATTERN = "h:mma z";
@Parameterized.Parameters
public static Collection<TimeZone> data() {
final String[] zoneIds = TimeZone.getAvailableIDs();
List<TimeZone> timeZones = new ArrayList<TimeZone>();
for (String zoneId : zoneIds) {
timeZones.add(TimeZone.getTimeZone(zoneId));
}
return timeZones;
}
private TimeZone timeZone;
public FastDatePrinterTimeZonesTest(TimeZone timeZone) {
this.timeZone = timeZone;
}
@Test
public void testCalendarTimezoneRespected() {
final Calendar cal = Calendar.getInstance(timeZone);
final SimpleDateFormat sdf = new SimpleDateFormat(PATTERN);
sdf.setTimeZone(timeZone);
final String expectedValue = sdf.format(cal.getTime());
final String actualValue = FastDateFormat.getInstance(PATTERN).format(cal);
assertEquals(expectedValue, actualValue);
}
}