Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Altering the if/else logic of HashCodeBuilder.append(Object) as per LANG-345 to get 20->40% speed improvements. This is because the code no longer uses Class.isArray() on every invocation. Many thanks to Venkatesh Prasad Ranganath for offering this improvement. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@564070 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Henri Yandell 2007-08-09 01:58:11 +00:00
parent 7fc38e82ec
commit 486740b60a
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
View File

@ -856,11 +856,6 @@ public HashCodeBuilder append(Object object) {
iTotal = iTotal * iConstant; iTotal = iTotal * iConstant;
} else { } else {
if (object.getClass().isArray() == false) {
// the simple case, not an array, just the element
iTotal = iTotal * iConstant + object.hashCode();
} else {
// 'Switch' on type of array, to dispatch to the correct handler // 'Switch' on type of array, to dispatch to the correct handler
// This handles multi dimensional arrays // This handles multi dimensional arrays
if (object instanceof long[]) { if (object instanceof long[]) {
@ -879,11 +874,12 @@ public HashCodeBuilder append(Object object) {
append((float[]) object); append((float[]) object);
} else if (object instanceof boolean[]) { } else if (object instanceof boolean[]) {
append((boolean[]) object); append((boolean[]) object);
} else { } else if (object instanceof Object[]) {
// Not an array of primitives // Not an array of primitives
append((Object[]) object); append((Object[]) object);
} else {
iTotal = iTotal * iConstant + object.hashCode();
} }
}
} }
return this; return this;
} }