Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "[LANG-1455] Add a DaemonThreadFactory.</action>" 

This reverts commit b30be60a81.
This commit is contained in:
Gary Gregory 2019-05-01 18:43:39 -04:00
parent b30be60a81
commit 4b77d24042
3 changed files with 0 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/changes/changes.xml
View File

@ -47,7 +47,6 @@ The <action> type attribute can be add,update,fix,remove.
<release version="3.10" date="YYYY-MM-DD" description="TBD">
<action issue="LANG-1450" type="fix" dev="chtompki">Generate javadoc jar on build.</action>
<action issue="LANG-1455" type="add" dev="ggregory">Add a DaemonThreadFactory.</action>
</release>
<release version="3.9" date="2019-04-09" description="New features and bug fixes. Requires Java 8, supports Java 9, 10, 11">

55
src/main/java/org/apache/commons/lang3/concurrent/DaemonThreadFactory.java
View File

@ -1,55 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.lang3.concurrent;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicInteger;
/**
* A {@link ThreadFactory} that produces daemon threads.
*
* @since 3.10
*/
public class DaemonThreadFactory implements ThreadFactory {
private static final String FORMAT = "%s-%s";
private final String namePrefix;
private final AtomicInteger threadCount = new AtomicInteger(0);
public DaemonThreadFactory() {
this(DaemonThreadFactory.class.getSimpleName());
}
public DaemonThreadFactory(final String prefix) {
this.namePrefix = prefix;
}
@Override
public Thread newThread(final Runnable runnable) {
if (runnable == null) {
return null;
}
final String name = String.format(FORMAT, this.namePrefix, this.threadCount.incrementAndGet());
final Thread thread = new Thread(runnable, name);
thread.setDaemon(true);
if (thread.getPriority() != Thread.NORM_PRIORITY) {
thread.setPriority(Thread.NORM_PRIORITY);
}
return thread;
}
}

50
src/test/java/org/apache/commons/lang3/concurrent/DaemonThreadFactoryTest.java
View File

@ -1,50 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.lang3.concurrent;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
public class DaemonThreadFactoryTest {
private static Runnable NOOP_RUNNABLE = new Runnable() {
@Override
public void run() {
// noop
}
};
@Test
public void testThreadFactory() {
final Thread thread = new DaemonThreadFactory().newThread(NOOP_RUNNABLE);
Assertions.assertTrue(thread.isDaemon());
final String name = thread.getName();
Assertions.assertTrue(name.startsWith("DaemonThreadFactory-"), name);
}
@Test
public void testThreadFactoryPrefix() {
final String expectedName = DaemonThreadFactoryTest.class.getSimpleName();
final Thread thread = new DaemonThreadFactory(expectedName).newThread(NOOP_RUNNABLE);
Assertions.assertTrue(thread.isDaemon());
final String name = thread.getName();
Assertions.assertTrue(name.startsWith(expectedName + "-"), name);
}
}