Changing the hashCode() method to return toHashCode() per the request in LANG-520

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@829285 13f79535-47bb-0310-9956-ffa450edef68

src/java/org/apache/commons/lang/builder/HashCodeBuilder.java

@@ -969,4 +969,16 @@ public int toHashCode() {
         return iTotal;
     }
 
+    /**
+     * <p>
+     * The computed <code>hashCode</code> from toHashCode() is returned due to the likelyhood 
+     * of bugs in mis-calling toHashCode() and the unlikelyness of it mattering what the hashCode for 
+     * HashCodeBuilder itself is.
+     * 
+     * @return <code>hashCode</code> based on the fields appended
+     */
+    public int hashCode() {
+        return toHashCode();
+    }
+
 }

src/test/org/apache/commons/lang/builder/HashCodeBuilderTest.java

@@ -547,4 +547,13 @@ public void testReflectionObjectCycle() {
         b.hashCode();
     }
 
+    /**
+     * Ensures LANG-520 remains true
+     */
+    public void testToHashCodeEqualsHashCode() {
+        HashCodeBuilder hcb = new HashCodeBuilder(17, 37).append(new Object()).append('a');
+        assertEquals("hashCode() is no longer returning the same value as toHashCode() - see LANG-520", 
+                     hcb.toHashCode(), hcb.hashCode());
+    }
+
 }