From 54afdb303535a62fe00e49e3ad5100ca9fc55d1e Mon Sep 17 00:00:00 2001 From: apirom9 Date: Fri, 25 Oct 2019 20:15:08 +0700 Subject: [PATCH] Add more test inputs for ArrayUtils.toMap() method (#472) * Add more test inputs for ArrayUtils.toMap() method in case zero-length array, all null values array, and duplicate keys in array * Fixed style * Fixed style * Fixed as changed request * Remove unused import statement --- .../org/apache/commons/lang3/ArrayUtilsTest.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java index 4b7c31d55..069466ea1 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java @@ -30,6 +30,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import java.lang.reflect.Constructor; import java.lang.reflect.Modifier; import java.util.Arrays; +import java.util.Collections; import java.util.Comparator; import java.util.Date; import java.util.Map; @@ -264,6 +265,17 @@ public class ArrayUtilsTest { } }}); assertEquals("bar", map.get("foo")); + + // Return empty map when got input array with length = 0 + assertEquals(Collections.emptyMap(), ArrayUtils.toMap(new Object[0])); + + // Test all null values + map = ArrayUtils.toMap(new Object[][] { {null, null}, {null, null} }); + assertEquals(Collections.singletonMap(null, null), map); + + // Test duplicate keys + map = ArrayUtils.toMap(new Object[][] { {"key", "value2"}, {"key", "value1"} }); + assertEquals(Collections.singletonMap("key", "value1"), map); } //-----------------------------------------------------------------------