From 5bfe84d27675cc2f05c0fc5fe972b34cce30c927 Mon Sep 17 00:00:00 2001 From: Sebastian Bazley Date: Sat, 14 Mar 2009 16:04:17 +0000 Subject: [PATCH] Make private fields final git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@754471 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/commons/lang/builder/HashCodeBuilder.java | 2 +- src/java/org/apache/commons/lang/builder/ToStringStyle.java | 2 +- src/test/org/apache/commons/lang/BitFieldTest.java | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java b/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java index e7d4470a2..16636e60a 100644 --- a/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java +++ b/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java @@ -102,7 +102,7 @@ public class HashCodeBuilder { * * @since 2.3 */ - private static ThreadLocal registry = new ThreadLocal() { + private static final ThreadLocal registry = new ThreadLocal() { @Override protected Object initialValue() { // The HashSet implementation is not synchronized, diff --git a/src/java/org/apache/commons/lang/builder/ToStringStyle.java b/src/java/org/apache/commons/lang/builder/ToStringStyle.java index 1060c9fb2..98e8fa756 100644 --- a/src/java/org/apache/commons/lang/builder/ToStringStyle.java +++ b/src/java/org/apache/commons/lang/builder/ToStringStyle.java @@ -133,7 +133,7 @@ public abstract class ToStringStyle implements Serializable { * to detect cyclical object references and avoid infinite loops. *

*/ - private static ThreadLocal registry = new ThreadLocal() { + private static final ThreadLocal registry = new ThreadLocal() { @Override protected Object initialValue() { // The HashSet implementation is not synchronized, diff --git a/src/test/org/apache/commons/lang/BitFieldTest.java b/src/test/org/apache/commons/lang/BitFieldTest.java index d1daef0e8..5cde68e19 100644 --- a/src/test/org/apache/commons/lang/BitFieldTest.java +++ b/src/test/org/apache/commons/lang/BitFieldTest.java @@ -41,9 +41,9 @@ public static Test suite() { return suite; } - private static BitField bf_multi = new BitField(0x3F80); - private static BitField bf_single = new BitField(0x4000); - private static BitField bf_zero = new BitField(0); + private static final BitField bf_multi = new BitField(0x3F80); + private static final BitField bf_single = new BitField(0x4000); + private static final BitField bf_zero = new BitField(0); /** * Constructor BitFieldTest