Apache/commons-lang
1
0
Fork 0
mirror of https://github.com/apache/commons-lang.git synced 2025-02-08 19:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[LANG-1723]: Throw NumberFormatException instead of IndexOutOfBoundsException in NumberUtils.getMantissa(String, int) (#1145)

Browse Source 
* [LANG-1723]: Wrap possible IOOBE with NumberFormatException

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>

* Fix unit test

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>

* Don't change the formatting

* Don't change the formatting

* Query length once

* Less duplication

---------

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Co-authored-by: Gary Gregory <garydgregory@users.noreply.github.com>
This commit is contained in:
Arthur Chan 2023-12-09 14:33:15 +00:00 committed by GitHub
parent 26e41e0199
commit 6a65b76f2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/org/apache/commons/lang3/math/NumberUtils.java
View File

@ -492,12 +492,16 @@ public static Number createNumber(final String str) {
* @param str the string representation of the number * @param str the string representation of the number
* @param stopPos the position of the exponent or decimal point * @param stopPos the position of the exponent or decimal point
* @return mantissa of the given number * @return mantissa of the given number
* @throws NumberFormatException if no mantissa can be retrieved
*/ */
private static String getMantissa(final String str, final int stopPos) { private static String getMantissa(final String str, final int stopPos) {
final char firstChar = str.charAt(0); final char firstChar = str.charAt(0);
final boolean hasSign = firstChar == '-' || firstChar == '+'; final boolean hasSign = firstChar == '-' || firstChar == '+';
final int length = str.length();
return hasSign ? str.substring(1, stopPos) : str.substring(0, stopPos); if (length <= (hasSign ? 1 : 0) || length < stopPos) {
throw new NumberFormatException(str + " is not a valid number.");
}
return hasSign ? str.substring(1, stopPos) : str.substring(0, stopPos);
} }
/** /**

1
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
View File

@ -724,6 +724,7 @@ public void testCreateNumberZero() {
@Test @Test
public void testInvalidNumber() { public void testInvalidNumber() {
assertThrows(NumberFormatException.class, () -> NumberUtils.createNumber("E123e.3")); assertThrows(NumberFormatException.class, () -> NumberUtils.createNumber("E123e.3"));
assertThrows(NumberFormatException.class, () -> NumberUtils.createNumber("-"));
} }
/** /**