Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix potential NPE by checking for object identity instead of comparing one property only

This commit is contained in:
Benedikt Ritter 2015-05-07 18:06:48 +02:00
parent 8ac3334a04
commit 6bb871786e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/java/org/apache/commons/lang3/ThreadUtilsTest.java
View File

@ -174,7 +174,7 @@ public class ThreadUtilsTest {
try { try {
t1.start(); t1.start();
t2.start(); t2.start();
assertEquals(t1.getName(), ThreadUtils.findThreadById(t1.getId()).getName()); assertSame(t1, ThreadUtils.findThreadById(t1.getId()));
assertSame(t2, ThreadUtils.findThreadById(t2.getId())); assertSame(t2, ThreadUtils.findThreadById(t2.getId()));
} finally { } finally {
t1.interrupt(); t1.interrupt();
@ -261,8 +261,8 @@ public class ThreadUtilsTest {
try { try {
t1.start(); t1.start();
t2.start(); t2.start();
assertEquals(t1.getName(), ThreadUtils.findThreadById(t1.getId(),"thread_group_DDZZ99__").getName()); assertSame(t1, ThreadUtils.findThreadById(t1.getId(),"thread_group_DDZZ99__"));
assertEquals(t2.getName(), ThreadUtils.findThreadById(t2.getId(),"thread_group_DDZZ99__").getName()); assertSame(t2, ThreadUtils.findThreadById(t2.getId(),"thread_group_DDZZ99__"));
assertNull(ThreadUtils.findThreadById(nonExistingId,"non_existent_thread_group_JJHHZZ__")); assertNull(ThreadUtils.findThreadById(nonExistingId,"non_existent_thread_group_JJHHZZ__"));
assertNull(ThreadUtils.findThreadById(nonExistingId,"thread_group_DDZZ99__")); assertNull(ThreadUtils.findThreadById(nonExistingId,"thread_group_DDZZ99__"));
} finally { } finally {