Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LANG-1002: Several predefined ISO FastDateFormats in DateFormatUtils are incorrect 

Since the naming template is ISO <ID>, new constants have been renamed to ISO_8601_...
Additionally, the constants represent the extended format. That should be reflected
in their names.
This commit is contained in:
Michael Osipov 2015-10-14 12:46:08 +02:00
parent 00fafe772c
commit 6d3796e64b
3 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/main/java/org/apache/commons/lang3/time/DateFormatUtils.java
View File

@ -46,14 +46,14 @@ public class DateFormatUtils {
* This format uses the default TimeZone in effect at the time of loading DateFormatUtils class. * This format uses the default TimeZone in effect at the time of loading DateFormatUtils class.
* @since 3.5 * @since 3.5
*/ */
public static final FastDateFormat ISO8601_DATETIME_FORMAT public static final FastDateFormat ISO_8601_EXTENDED_DATETIME_FORMAT
= FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss"); = FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss");
/** /**
* @deprecated - as of 4.0, ISO_DATETIME_FORMAT will be replaced by ISO8601_DATETIME_FORMAT. * @deprecated - as of 4.0, ISO_DATETIME_FORMAT will be replaced by ISO_8601_EXTENDED_DATETIME_FORMAT.
*/ */
@Deprecated @Deprecated
public static final FastDateFormat ISO_DATETIME_FORMAT = ISO8601_DATETIME_FORMAT; public static final FastDateFormat ISO_DATETIME_FORMAT = ISO_8601_EXTENDED_DATETIME_FORMAT;
/** /**
* ISO 8601 formatter for date-time with time zone. * ISO 8601 formatter for date-time with time zone.
@ -61,14 +61,14 @@ public class DateFormatUtils {
* This format uses the default TimeZone in effect at the time of loading DateFormatUtils class. * This format uses the default TimeZone in effect at the time of loading DateFormatUtils class.
* @since 3.5 * @since 3.5
*/ */
public static final FastDateFormat ISO8601_DATETIME_TIME_ZONE_FORMAT public static final FastDateFormat ISO_8601_EXTENDED_DATETIME_TIME_ZONE_FORMAT
= FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ssZZ"); = FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ssZZ");
/** /**
* @deprecated - as of 4.0, ISO_DATETIME_TIME_ZONE_FORMAT will be replaced by ISO8601_DATETIME_TIME_ZONE_FORMAT. * @deprecated - as of 4.0, ISO_DATETIME_TIME_ZONE_FORMAT will be replaced by ISO_8601_EXTENDED_DATETIME_TIME_ZONE_FORMAT.
*/ */
@Deprecated @Deprecated
public static final FastDateFormat ISO_DATETIME_TIME_ZONE_FORMAT = ISO8601_DATETIME_TIME_ZONE_FORMAT; public static final FastDateFormat ISO_DATETIME_TIME_ZONE_FORMAT = ISO_8601_EXTENDED_DATETIME_TIME_ZONE_FORMAT;
/** /**
* ISO 8601 formatter for date without time zone. * ISO 8601 formatter for date without time zone.
@ -76,14 +76,14 @@ public class DateFormatUtils {
* This format uses the default TimeZone in effect at the time of loading DateFormatUtils class. * This format uses the default TimeZone in effect at the time of loading DateFormatUtils class.
* @since 3.5 * @since 3.5
*/ */
public static final FastDateFormat ISO8601_DATE_FORMAT public static final FastDateFormat ISO_8601_EXTENDED_DATE_FORMAT
= FastDateFormat.getInstance("yyyy-MM-dd"); = FastDateFormat.getInstance("yyyy-MM-dd");
/** /**
* @deprecated - as of 4.0, ISO_DATE_FORMAT will be replaced by ISO8601_DATE_FORMAT. * @deprecated - as of 4.0, ISO_DATE_FORMAT will be replaced by ISO_8601_EXTENDED_DATE_FORMAT.
*/ */
@Deprecated @Deprecated
public static final FastDateFormat ISO_DATE_FORMAT = ISO8601_DATE_FORMAT; public static final FastDateFormat ISO_DATE_FORMAT = ISO_8601_EXTENDED_DATE_FORMAT;
/** /**
* ISO 8601-like formatter for date with time zone. * ISO 8601-like formatter for date with time zone.
@ -126,14 +126,14 @@ public class DateFormatUtils {
* This format uses the default TimeZone in effect at the time of loading DateFormatUtils class. * This format uses the default TimeZone in effect at the time of loading DateFormatUtils class.
* @since 3.5 * @since 3.5
*/ */
public static final FastDateFormat ISO8601_TIME_FORMAT public static final FastDateFormat ISO_8601_EXTENDED_TIME_FORMAT
= FastDateFormat.getInstance("HH:mm:ss"); = FastDateFormat.getInstance("HH:mm:ss");
/** /**
* @deprecated - as of 4.0, ISO_TIME_NO_T_FORMAT will be replaced by ISO8601_TIME_FORMAT. * @deprecated - as of 4.0, ISO_TIME_NO_T_FORMAT will be replaced by ISO_8601_EXTENDED_TIME_FORMAT.
*/ */
@Deprecated @Deprecated
public static final FastDateFormat ISO_TIME_NO_T_FORMAT = ISO8601_TIME_FORMAT; public static final FastDateFormat ISO_TIME_NO_T_FORMAT = ISO_8601_EXTENDED_TIME_FORMAT;
/** /**
* ISO 8601 formatter for time with time zone. * ISO 8601 formatter for time with time zone.
@ -141,14 +141,14 @@ public class DateFormatUtils {
* This format uses the default TimeZone in effect at the time of loading DateFormatUtils class. * This format uses the default TimeZone in effect at the time of loading DateFormatUtils class.
* @since 3.5 * @since 3.5
*/ */
public static final FastDateFormat ISO8601_TIME_TIME_ZONE_FORMAT public static final FastDateFormat ISO_8601_EXTENDED_TIME_TIME_ZONE_FORMAT
= FastDateFormat.getInstance("HH:mm:ssZZ"); = FastDateFormat.getInstance("HH:mm:ssZZ");
/** /**
* @deprecated - as of 4.0, ISO_TIME_NO_T_TIME_ZONE_FORMAT will be replaced by ISO8601_TIME_TIME_ZONE_FORMAT. * @deprecated - as of 4.0, ISO_TIME_NO_T_TIME_ZONE_FORMAT will be replaced by ISO_8601_EXTENDED_TIME_TIME_ZONE_FORMAT.
*/ */
@Deprecated @Deprecated
public static final FastDateFormat ISO_TIME_NO_T_TIME_ZONE_FORMAT = ISO8601_TIME_TIME_ZONE_FORMAT; public static final FastDateFormat ISO_TIME_NO_T_TIME_ZONE_FORMAT = ISO_8601_EXTENDED_TIME_TIME_ZONE_FORMAT;
/** /**
* SMTP (and probably other) date headers. * SMTP (and probably other) date headers.

2
src/main/java/org/apache/commons/lang3/time/FastDateFormat.java
View File

@ -57,7 +57,7 @@ import java.util.TimeZone;
* This pattern letter can be used here (on all JDK versions).</p> * This pattern letter can be used here (on all JDK versions).</p>
* *
* <p>In addition, the pattern {@code 'ZZ'} has been made to represent * <p>In addition, the pattern {@code 'ZZ'} has been made to represent
* ISO 8601 full format time zones (eg. {@code +08:00} or {@code -11:00}). * ISO 8601 extended format time zones (eg. {@code +08:00} or {@code -11:00}).
* This introduces a minor incompatibility with Java 1.4, but at a gain of * This introduces a minor incompatibility with Java 1.4, but at a gain of
* useful functionality.</p> * useful functionality.</p>
* *

2
src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
View File

@ -61,7 +61,7 @@ import org.apache.commons.lang3.exception.ExceptionUtils;
* This pattern letter can be used here (on all JDK versions).</p> * This pattern letter can be used here (on all JDK versions).</p>
* *
* <p>In addition, the pattern {@code 'ZZ'} has been made to represent * <p>In addition, the pattern {@code 'ZZ'} has been made to represent
* ISO 8601 full format time zones (eg. {@code +08:00} or {@code -11:00}). * ISO 8601 extended format time zones (eg. {@code +08:00} or {@code -11:00}).
* This introduces a minor incompatibility with Java 1.4, but at a gain of * This introduces a minor incompatibility with Java 1.4, but at a gain of
* useful functionality.</p> * useful functionality.</p>
* *