Fix IndexOutOfBoundsException on padding

bug 35756, from Reuben Sivan

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@240418 13f79535-47bb-0310-9956-ffa450edef68

project.xml

@@ -301,6 +301,9 @@ limitations under the License.
 		<contributor>
 			<name>Sean Schofield</name>
 		</contributor>
+		<contributor>
+			<name>Reuben Sivan</name>
+		</contributor>
 		<contributor>
 			<name>Ville Skytta</name>
 		</contributor>

src/java/org/apache/commons/lang/StringUtils.java

@@ -110,6 +110,7 @@ import java.util.List;
  * @author Phil Steitz
  * @author Al Chou
  * @author Michael Davey
+ * @author Reuben Sivan
  * @since 1.0
  * @version $Id$
  */
@@ -152,7 +153,7 @@ public class StringUtils {
      *
      * <p>Used for efficient space padding. The length of each String expands as needed.</p>
      */
-    private static final String[] PADDING = new String[Character.MAX_VALUE];
+    private static final String[] PADDING = new String[Character.MAX_VALUE + 1];
 
     static {
         // space padding is most common, start with 64 chars

src/test/org/apache/commons/lang/StringUtilsTest.java

@@ -1126,6 +1126,7 @@ public class StringUtilsTest extends TestCase {
         assertEquals("     ", StringUtils.leftPad("", 5, ' '));
         assertEquals("  abc", StringUtils.leftPad("abc", 5, ' '));
         assertEquals("xxabc", StringUtils.leftPad("abc", 5, 'x'));
+        assertEquals("\uffff\uffffabc", StringUtils.leftPad("abc", 5, '\uffff'));
         assertEquals("abc", StringUtils.leftPad("abc", 2, ' '));
         String str = StringUtils.leftPad("aaa", 10000, 'a');  // bigger than pad length
         assertEquals(10000, str.length());