From 8069e1c1ce7ec864c7bab2eae880742fac02376b Mon Sep 17 00:00:00 2001
From: Allon Mureinik <amureini@redhat.com>
Date: Sat, 1 Apr 2017 12:18:53 +0300
Subject: [PATCH] Exclude SF_SWITCH_NO_DEFAULT on FastDatePrinter

FastDatePrinter#appendFullDigits uses a switch case without break
statements.

SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and
leave us with no choice but to suppress it.
---
 findbugs-exclude-filter.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index edc6eadea..23dddbdf7 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -150,6 +150,14 @@
     <Bug pattern="SF_SWITCH_NO_DEFAULT" />
   </Match>
 
+  <!-- Reason: FindBugs cannot correctly recognize default branches in switch statements without break statements.
+   See, e.g., the report at https://sourceforge.net/p/findbugs/bugs/1298 -->
+  <Match>
+    <Class name="org.apache.commons.lang3.time.FastDatePrinter"/>
+    <Method name="appendFullDigits" params="java.lang.Appendable, int, int"/>
+    <Bug pattern="SF_SWITCH_NO_DEFAULT" />
+  </Match>
+
   <!-- Reason: The fallthrough on the swich stateme is intentional -->
   <Match>
     <Class name="org.apache.commons.lang3.time.FastDatePrinter"/>