Bump commons-parent from 69 to 70

- Bump to spotbugs:4.8.5.0
- Bump to PMD 7.1.0

pom.xml

@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.commons</groupId>
     <artifactId>commons-parent</artifactId>
-    <version>69</version>
+    <version>70</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <artifactId>commons-lang3</artifactId>
@@ -190,7 +190,10 @@
           <version>${commons.pmd.version}</version>
           <configuration>
             <targetJdk>${maven.compiler.target}</targetJdk>
-            <excludeFromFailureFile>src/conf/exclude-pmd.properties</excludeFromFailureFile>
+            <excludeFromFailureFile>src/conf/pmd-exclude.properties</excludeFromFailureFile>
+            <rulesets>
+              <ruleset>src/conf/pmd-ruleset.xml</ruleset>
+            </rulesets>
           </configuration>
         </plugin>
         <plugin>

src/changes/changes.xml

@@ -135,7 +135,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">StringUtils.stripAccents(String) doesn't handle U with bar.</action> 
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">StringUtils.stripAccents(String) doesn't handle T with stroke.</action> 
     <!-- UPDATE -->
-    <action                   type="update" dev="sebb" due-to="Dependabot">Bump commons-parent from 64 to 69 #1194.</action>
+    <action                   type="update" dev="sebb" due-to="Dependabot, Gary Gregory">Bump commons-parent from 64 to 70 #1194.</action>
     <action                   type="update" dev="ggregory" due-to="Dependabot">Bump org.codehaus.mojo:exec-maven-plugin from 3.1.1 to 3.2.0 #1175.</action>
     <action                   type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-text from 1.11.0 to 1.12.0 #1200.</action> 
     <!-- REMOVE -->

src/conf/pmd-ruleset.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+<ruleset name="mybraces" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+  <description>Excludes from default PMD rules.</description>
+  <rule ref="category/java/errorprone.xml/EmptyCatchBlock">
+    <properties>
+      <property name="allowCommentedBlocks" value="true" />
+      <property name="allowExceptionNameRegex" value="^(ignored|expected)$" />
+    </properties>
+  </rule>
+</ruleset>

src/conf/spotbugs-exclude-filter.xml

@@ -203,4 +203,18 @@
     <Method name="requireNonNull" />
     <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE" />
   </Match>
+  <!-- What can be done?-->
+  <Match>
+    <Class name="org.apache.commons.lang3.event.EventListenerSupport" />
+    <Method name="readObject" />
+    <Bug pattern="MC_OVERRIDABLE_METHOD_CALL_IN_READ_OBJECT" />
+  </Match>
+  <!-- Fundamental disagreement with SB: It should be OK to have predefined instances and allow new instances. -->
+  <Match>
+    <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
+  </Match>
+  <!-- Fundamental disagreement with SB: It should be OK to have predefined instances and allow new instances. -->
+  <Match>
+    <Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE" />
+  </Match>
 </FindBugsFilter>