diff --git a/src/test/java/org/apache/commons/lang3/ValidateTest.java b/src/test/java/org/apache/commons/lang3/ValidateTest.java index 41033864e..cf1a907f3 100644 --- a/src/test/java/org/apache/commons/lang3/ValidateTest.java +++ b/src/test/java/org/apache/commons/lang3/ValidateTest.java @@ -23,8 +23,6 @@ import java.lang.reflect.Constructor; import java.lang.reflect.Modifier; -import java.util.AbstractList; -import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.List; @@ -37,23 +35,12 @@ import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; /** * Unit tests {@link org.apache.commons.lang3.Validate}. */ class ValidateTest { - @Test - void testConstructor() { - assertNotNull(new Validate()); - final Constructor[] cons = Validate.class.getDeclaredConstructors(); - assertEquals(1, cons.length); - assertTrue(Modifier.isPublic(cons[0].getModifiers())); - assertTrue(Modifier.isPublic(Validate.class.getModifiers())); - assertFalse(Modifier.isFinal(Validate.class.getModifiers())); - } - @Nested class IsTrue { @@ -1882,4 +1869,29 @@ void shouldThrowIllegalArgumentExceptionWithGiventMessageWhenClassIsNotAssignabl } } } + + @Nested + class UtilClassConventions { + + @Test + void instancesCanBeConstrcuted() { + assertNotNull(new Validate()); + } + + @Test + void hasOnlyOnePublicConstructor() { + final Constructor[] cons = Validate.class.getDeclaredConstructors(); + assertEquals(1, cons.length); + } + + @Test + void isPublicClass() { + assertTrue(Modifier.isPublic(Validate.class.getModifiers())); + } + + @Test + void isNonFinalClass() { + assertFalse(Modifier.isFinal(Validate.class.getModifiers())); + } + } }