Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify expressions. 

Use final.
Parse to primitive.
This commit is contained in:
Gary Gregory 2021-07-10 09:52:40 -04:00
parent 627a699bd0
commit 929c5f6e68
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/apache/commons/lang3/stream/Streams.java
View File

@ -425,7 +425,7 @@ public class Streams {
* @since 3.13.0 * @since 3.13.0
*/ */
@SafeVarargs // Creating a stream from an array is safe @SafeVarargs // Creating a stream from an array is safe
public static <T> Stream<T> of(T... values) { public static <T> Stream<T> of(final T... values) {
return values == null ? Stream.empty() : Stream.of(values); return values == null ? Stream.empty() : Stream.of(values);
} }

2
src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
View File

@ -100,7 +100,7 @@ public class RandomUtilsTest {
@Test @Test
public void testBoolean() { public void testBoolean() {
final boolean result = RandomUtils.nextBoolean(); final boolean result = RandomUtils.nextBoolean();
assertTrue(result == true || result == false); assertTrue(result || !result);
} }
/** /**

4
src/test/java/org/apache/commons/lang3/StreamsTest.java
View File

@ -84,8 +84,8 @@ public class StreamsTest {
protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T pThrowable) { protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T pThrowable) {
return s -> { return s -> {
final Integer i = Integer.valueOf(s); final int i = Integer.parseInt(s);
if (i.intValue() == 4) { if (i == 4) {
throw pThrowable; throw pThrowable;
} }
}; };

4
src/test/java/org/apache/commons/lang3/stream/StreamsTest.java
View File

@ -46,8 +46,8 @@ public class StreamsTest {
protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T pThrowable) { protected <T extends Throwable> FailableConsumer<String, T> asIntConsumer(final T pThrowable) {
return s -> { return s -> {
final Integer i = Integer.valueOf(s); final int i = Integer.parseInt(s);
if (i.intValue() == 4) { if (i == 4) {
throw pThrowable; throw pThrowable;
} }
}; };