[Bug 35966] - [lang] StrBuilderTest#testReplaceStringString fails. From Nathan Beyer nbeyer@kc.rr.com.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk@226922 13f79535-47bb-0310-9956-ffa450edef68

src/java/org/apache/commons/lang/text/StrBuilder.java

@@ -1031,7 +1031,7 @@ public StrBuilder delete(String str) {
     public StrBuilder replace(int startIndex, int endIndex, String str) {
         endIndex = validateRange(startIndex, endIndex);
         int insertLen = str.length();
-        int removeLen = endIndex = startIndex;
+        int removeLen = endIndex - startIndex;
         int newSize = size - removeLen + insertLen;
         if (insertLen > removeLen) {
             ensureCapacity(newSize);
@@ -1462,12 +1462,15 @@ public int lastIndexOf(String str, int startIndex) {
      * @return this, to enable chaining
      */
     public StrBuilder reverse() {
+        if (size == 0) {
+            return this;
+        }
+        
         int half = size / 2;
-        char swap;
-        for (int i = 0; i < half; i++) {
-            swap = buf[i];
-            buf[i] = buf[size - i];
-            buf[size - i] = swap;
+        for (int leftIdx = 0, rightIdx = size - 1; leftIdx < half; leftIdx++,rightIdx--) {
+            char swap = buf[leftIdx];
+            buf[leftIdx] = buf[rightIdx];
+            buf[rightIdx] = swap;
         }
         return this;
     }

src/test/org/apache/commons/lang/text/StrBuilderTest.java

@@ -1324,11 +1324,25 @@ public void testAppendStrBuilder() {
         assertEquals("", sb.toString());
     }
     
-    public void toStringBuffer() {
+    public void testStringBuffer() {
         StrBuilder sb = new StrBuilder();
         assertEquals (new StringBuffer().toString(), sb.toStringBuffer().toString());
         
         sb.append("junit");
         assertEquals(new StringBuffer("junit").toString(), sb.toStringBuffer().toString());
     }
+    
+    public void testReverse() {
+        StrBuilder sb = new StrBuilder();
+        
+        String actual = sb.reverse().toString();
+        assertEquals ("", actual);
+        
+        sb.append(true);
+        actual = sb.reverse().toString();
+        assertEquals("eurt", actual);
+        
+        actual = sb.reverse().toString();
+        assertEquals("true", actual);
+    }
 }