From 992e7cf6c8cb1a83c23f2499efe06856ca8b59c4 Mon Sep 17 00:00:00 2001
From: Gary Gregory <gardgregory@gmail.com>
Date: Fri, 10 May 2019 08:58:17 -0400
Subject: [PATCH] - Javadoc.

- checkstyle.version 8.18 -> 8.20.
- [LANG-1458] Add EMPTY_ARRAY constants to classes in
org.apache.commons.lang3.tuple
---
 checkstyle.xml                                                 | 3 +--
 pom.xml                                                        | 2 +-
 src/changes/changes.xml                                        | 1 +
 .../java/org/apache/commons/lang3/tuple/ImmutablePair.java     | 2 ++
 .../java/org/apache/commons/lang3/tuple/ImmutableTriple.java   | 3 +++
 src/main/java/org/apache/commons/lang3/tuple/MutablePair.java  | 2 ++
 .../java/org/apache/commons/lang3/tuple/MutableTriple.java     | 3 +++
 7 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index eda9e1d9a..0adaecc1e 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -20,7 +20,7 @@ limitations under the License.
     "-//Puppy Crawl//DTD Check Configuration 1.1//EN"
     "http://www.puppycrawl.com/dtds/configuration_1_1.dtd">
 
-<!-- commons lang customization of default Checkstyle behavior -->
+<!-- Apache Commons Lang customization of default Checkstyle behavior -->
 <module name="Checker">
   <property name="localeLanguage" value="en"/>
   <module name="JavadocPackage"/>
@@ -39,7 +39,6 @@ limitations under the License.
     <property name="file" value="checkstyle-suppressions.xml"/>
   </module>
   <module name="TreeWalker">
-    <property name="cacheFile" value="target/cachefile"/>
     <module name="AvoidStarImport"/>
     <module name="IllegalImport"/>
     <module name="RedundantImport"/>
diff --git a/pom.xml b/pom.xml
index 410e11c36..2010bba76 100644
--- a/pom.xml
+++ b/pom.xml
@@ -597,7 +597,7 @@
     <commons.encoding>utf-8</commons.encoding>
 
     <checkstyle.plugin.version>3.0.0</checkstyle.plugin.version>
-    <checkstyle.version>8.18</checkstyle.version>
+    <checkstyle.version>8.20</checkstyle.version>
 
     <spotbugs.plugin.version>3.1.11</spotbugs.plugin.version>
     <japicmp.skip>false</japicmp.skip>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 56f724af4..4650f69c3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -49,6 +49,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action issue="LANG-1450" type="fix" dev="chtompki">Generate javadoc jar on build.</action>
     <action issue="LANG-1457" type="add" dev="ggregory">Add ExceptionUtils.throwableOfType(Throwable, Class) and friends.</action>
     <action issue="LANG-1458" type="add" dev="ggregory">Add EMPTY_ARRAY constants to classes in org.apache.commons.lang3.tuple.</action>
+    <action                   type="update" dev="ggregory">checkstyle.version 8.18 -> 8.20.</action>
   </release>
 
   <release version="3.9" date="2019-04-09" description="New features and bug fixes. Requires Java 8, supports Java 9, 10, 11">
diff --git a/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java b/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java
index 30478da37..39d1effb3 100644
--- a/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java
+++ b/src/main/java/org/apache/commons/lang3/tuple/ImmutablePair.java
@@ -46,6 +46,8 @@ public final class ImmutablePair<L, R> extends Pair<L, R> {
     /**
      * Returns the empty array singleton that can be assigned without compiler warning.
      *
+     * @param <L> the left element type
+     * @param <R> the right element type
      * @return the empty array singleton that can be assigned without compiler warning.
      *
      * @since 3.10.
diff --git a/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java b/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java
index 1453dd565..b35234030 100644
--- a/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java
+++ b/src/main/java/org/apache/commons/lang3/tuple/ImmutableTriple.java
@@ -47,6 +47,9 @@ public final class ImmutableTriple<L, M, R> extends Triple<L, M, R> {
     /**
      * Returns the empty array singleton that can be assigned without compiler warning.
      *
+     * @param <L> the left element type
+     * @param <M> the middle element type
+     * @param <R> the right element type
      * @return the empty array singleton that can be assigned without compiler warning.
      *
      * @since 3.10.
diff --git a/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java b/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java
index c377e809b..d0e06d938 100644
--- a/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java
+++ b/src/main/java/org/apache/commons/lang3/tuple/MutablePair.java
@@ -41,6 +41,8 @@ public class MutablePair<L, R> extends Pair<L, R> {
     /**
      * Returns the empty array singleton that can be assigned without compiler warning.
      *
+     * @param <L> the left element type
+     * @param <R> the right element type
      * @return the empty array singleton that can be assigned without compiler warning.
      *
      * @since 3.10.
diff --git a/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java b/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java
index 4a8fe38d6..15db8b9e4 100644
--- a/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java
+++ b/src/main/java/org/apache/commons/lang3/tuple/MutableTriple.java
@@ -42,6 +42,9 @@ public class MutableTriple<L, M, R> extends Triple<L, M, R> {
     /**
      * Returns the empty array singleton that can be assigned without compiler warning.
      *
+     * @param <L> the left element type
+     * @param <M> the middle element type
+     * @param <R> the right element type
      * @return the empty array singleton that can be assigned without compiler warning.
      *
      * @since 3.10.