Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Predictable randomness in shuffle tests. Closes #317 from Allon 

Murienik's PR https://github.com/apache/commons-lang/pull/317
This commit is contained in:
Gary Gregory 2018-03-09 15:06:03 -07:00
parent 1a8d276278
commit 9c886bd4a1
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
View File

@ -32,6 +32,7 @@ import java.util.Arrays;
import java.util.Comparator; import java.util.Comparator;
import java.util.Date; import java.util.Date;
import java.util.Map; import java.util.Map;
import java.util.Random;
import org.junit.Test; import org.junit.Test;
@ -41,6 +42,9 @@ import org.junit.Test;
@SuppressWarnings("deprecation") // deliberate use of deprecated code @SuppressWarnings("deprecation") // deliberate use of deprecated code
public class ArrayUtilsTest { public class ArrayUtilsTest {
/** A predefined seed used to initialize {@link Random} in order to get predictable results */
private static final long SEED = 16111981L;
//----------------------------------------------------------------------- //-----------------------------------------------------------------------
@Test @Test
public void testConstructor() { public void testConstructor() {
@ -5007,7 +5011,7 @@ public class ArrayUtilsTest {
final String[] array1 = new String[]{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"}; final String[] array1 = new String[]{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"};
final String[] array2 = ArrayUtils.clone(array1); final String[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final String element : array2) { for (final String element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5019,7 +5023,7 @@ public class ArrayUtilsTest {
final boolean[] array1 = new boolean[]{true, false, true, true, false, false, true, false, false, true}; final boolean[] array1 = new boolean[]{true, false, true, true, false, false, true, false, false, true};
final boolean[] array2 = ArrayUtils.clone(array1); final boolean[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
assertEquals(5, ArrayUtils.removeAllOccurences(array1, true).length); assertEquals(5, ArrayUtils.removeAllOccurences(array1, true).length);
} }
@ -5029,7 +5033,7 @@ public class ArrayUtilsTest {
final byte[] array1 = new byte[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final byte[] array1 = new byte[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final byte[] array2 = ArrayUtils.clone(array1); final byte[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final byte element : array2) { for (final byte element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5041,7 +5045,7 @@ public class ArrayUtilsTest {
final char[] array1 = new char[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final char[] array1 = new char[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final char[] array2 = ArrayUtils.clone(array1); final char[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final char element : array2) { for (final char element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5053,7 +5057,7 @@ public class ArrayUtilsTest {
final short[] array1 = new short[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final short[] array1 = new short[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final short[] array2 = ArrayUtils.clone(array1); final short[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final short element : array2) { for (final short element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5065,7 +5069,7 @@ public class ArrayUtilsTest {
final int[] array1 = new int[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final int[] array1 = new int[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final int[] array2 = ArrayUtils.clone(array1); final int[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final int element : array2) { for (final int element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5077,7 +5081,7 @@ public class ArrayUtilsTest {
final long[] array1 = new long[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final long[] array1 = new long[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final long[] array2 = ArrayUtils.clone(array1); final long[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final long element : array2) { for (final long element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5089,7 +5093,7 @@ public class ArrayUtilsTest {
final float[] array1 = new float[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final float[] array1 = new float[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final float[] array2 = ArrayUtils.clone(array1); final float[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final float element : array2) { for (final float element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));
@ -5101,7 +5105,7 @@ public class ArrayUtilsTest {
final double[] array1 = new double[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; final double[] array1 = new double[]{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
final double[] array2 = ArrayUtils.clone(array1); final double[] array2 = ArrayUtils.clone(array1);
ArrayUtils.shuffle(array1); ArrayUtils.shuffle(array1, new Random(SEED));
assertFalse(Arrays.equals(array1, array2)); assertFalse(Arrays.equals(array1, array2));
for (final double element : array2) { for (final double element : array2) {
assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element)); assertTrue("Element " + element + " not found", ArrayUtils.contains(array1, element));