Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Better concurrency with the Java 8 API ConcurrentMap#computeIfAbsent().

This commit is contained in:
Gary Gregory 2022-03-20 14:27:10 -04:00
parent 5648bc42e2
commit 9dd8584963
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
View File

@ -1299,6 +1299,7 @@ public class FastDatePrinter implements DatePrinter, Serializable {
private static final ConcurrentMap<TimeZoneDisplayKey, String> cTimeZoneDisplayCache = private static final ConcurrentMap<TimeZoneDisplayKey, String> cTimeZoneDisplayCache =
new ConcurrentHashMap<>(7); new ConcurrentHashMap<>(7);
/** /**
* <p>Gets the time zone display name, using a cache for performance.</p> * <p>Gets the time zone display name, using a cache for performance.</p>
* *
@ -1310,16 +1311,8 @@ public class FastDatePrinter implements DatePrinter, Serializable {
*/ */
static String getTimeZoneDisplay(final TimeZone tz, final boolean daylight, final int style, final Locale locale) { static String getTimeZoneDisplay(final TimeZone tz, final boolean daylight, final int style, final Locale locale) {
final TimeZoneDisplayKey key = new TimeZoneDisplayKey(tz, daylight, style, locale); final TimeZoneDisplayKey key = new TimeZoneDisplayKey(tz, daylight, style, locale);
String value = cTimeZoneDisplayCache.get(key);
if (value == null) {
// This is a very slow call, so cache the results. // This is a very slow call, so cache the results.
value = tz.getDisplayName(daylight, style, locale); return cTimeZoneDisplayCache.computeIfAbsent(key, k -> tz.getDisplayName(daylight, style, locale));
final String prior = cTimeZoneDisplayCache.putIfAbsent(key, value);
if (prior != null) {
value= prior;
}
}
return value;
} }
/** /**