From 9feaf9d7ffe3f4438ccdace378f49f1d4dadd418 Mon Sep 17 00:00:00 2001 From: Nicolas Date: Thu, 5 Sep 2019 19:20:04 +0200 Subject: [PATCH] LANG-1485 : Add getters for lhs and rhs objects in DiffResult (#451) * LANG-1485 : Add getters for lhs and rhs objects in DiffResult * add @since and rename getters to getLeft and getRight * fix typo on @since tag --- .../commons/lang3/builder/DiffResult.java | 20 +++++++++++++++++++ .../commons/lang3/builder/DiffResultTest.java | 12 +++++++++++ 2 files changed, 32 insertions(+) diff --git a/src/main/java/org/apache/commons/lang3/builder/DiffResult.java b/src/main/java/org/apache/commons/lang3/builder/DiffResult.java index d6d031c95..bb1ceeca2 100644 --- a/src/main/java/org/apache/commons/lang3/builder/DiffResult.java +++ b/src/main/java/org/apache/commons/lang3/builder/DiffResult.java @@ -88,6 +88,26 @@ public class DiffResult implements Iterable> { } } + /** + *

Returns the object the right object has been compared to.

+ * + * @return the left object of the diff + * @since 3.10 + */ + public Object getLeft() { + return this.lhs; + } + + /** + *

Returns the object the left object has been compared to.

+ * + * @return the right object of the diff + * @since 3.10 + */ + public Object getRight() { + return this.rhs; + } + /** *

* Returns an unmodifiable list of {@code Diff}s. The list may be empty if diff --git a/src/test/java/org/apache/commons/lang3/builder/DiffResultTest.java b/src/test/java/org/apache/commons/lang3/builder/DiffResultTest.java index e32145264..b92b34fb0 100644 --- a/src/test/java/org/apache/commons/lang3/builder/DiffResultTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/DiffResultTest.java @@ -146,4 +146,16 @@ public void testNoDifferencesString() { SHORT_STYLE).build(); assertEquals(DiffResult.OBJECTS_SAME_STRING, diffResult.toString()); } + + @Test + public void testLeftAndRightGetters() { + final SimpleClass left = new SimpleClass(true); + final SimpleClass right = new SimpleClass(false); + + final List> diffs = left.diff(right).getDiffs(); + final DiffResult diffResult = new DiffResult(left, right, diffs, SHORT_STYLE); + + assertEquals(left, diffResult.getLeft()); + assertEquals(right, diffResult.getRight()); + } }