Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix for LANG-477 OutOfMemory with custom format registry and a pattern containing single quotes - thanks to Duncan Eley 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@733169 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Niall Pemberton 2009-01-09 22:05:14 +00:00
parent eb8b39b145
commit a38e2e942d
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/java/org/apache/commons/lang/text/ExtendedMessageFormat.java
View File

@ -419,6 +419,7 @@ public class ExtendedMessageFormat extends MessageFormat {
int start = pos.getIndex();
char[] c = pattern.toCharArray();
if (escapingOn && c[start] == QUOTE) {
next(pos);
return appendTo == null ? null : appendTo.append(QUOTE);
}
int lastHold = start;

9
src/test/org/apache/commons/lang/text/ExtendedMessageFormatTest.java
View File

@ -92,6 +92,15 @@ public class ExtendedMessageFormatTest extends TestCase {
assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] {"foo", "BAR"}));
}
/**
* Test Bug LANG-477 - out of memory error with escaped quote
*/
public void testEscapedQuote_LANG_477() {
String pattern = "it''s a {0,lower} 'test'!";
ExtendedMessageFormat emf = new ExtendedMessageFormat(pattern, registry);
assertEquals("it's a dummy test!", emf.format(new Object[] {"DUMMY"}));
}
/**
* Test extended and built in formats.
*/