Apache
/
commons-lang
mirror of https://github.com/apache/commons-lang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

One less boolean operation per primitive append()

This commit is contained in:
Gary Gregory 2024-03-16 07:52:48 -04:00
parent da5a9c2523
commit ab8c02fb11
1 changed files with 16 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
View File

@ -438,10 +438,9 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final byte lhs, final byte rhs) {
if (!isEquals) {
return this;
if (isEquals) {
isEquals = lhs == rhs;
}
isEquals = lhs == rhs;
return this;
}
@ -484,10 +483,9 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final char lhs, final char rhs) {
if (!isEquals) {
return this;
if (isEquals) {
isEquals = lhs == rhs;
}
isEquals = lhs == rhs;
return this;
}
@ -536,10 +534,10 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final double lhs, final double rhs) {
if (!isEquals) {
return this;
if (isEquals) {
return append(Double.doubleToLongBits(lhs), Double.doubleToLongBits(rhs));
}
return append(Double.doubleToLongBits(lhs), Double.doubleToLongBits(rhs));
return this;
}
/**
@ -587,10 +585,10 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final float lhs, final float rhs) {
if (!isEquals) {
return this;
if (isEquals) {
return append(Float.floatToIntBits(lhs), Float.floatToIntBits(rhs));
}
return append(Float.floatToIntBits(lhs), Float.floatToIntBits(rhs));
return this;
}
/**
@ -632,10 +630,9 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final int lhs, final int rhs) {
if (!isEquals) {
return this;
if (isEquals) {
isEquals = lhs == rhs;
}
isEquals = lhs == rhs;
return this;
}
@ -680,10 +677,9 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final long lhs, final long rhs) {
if (!isEquals) {
return this;
if (isEquals) {
isEquals = lhs == rhs;
}
isEquals = lhs == rhs;
return this;
}
@ -796,10 +792,9 @@ public class EqualsBuilder implements Builder<Boolean> {
* @return this
*/
public EqualsBuilder append(final short lhs, final short rhs) {
if (!isEquals) {
return this;
if (isEquals) {
isEquals = lhs == rhs;
}
isEquals = lhs == rhs;
return this;
}